Merged
Conversation
matthew-lidar
requested review from
benemer,
mehermvr,
nachovizzo,
saurabh1002 and
tizianoGuadagnino
as code owners
Contributor
Author
|
One option for fixing the C++ builds could be to install cmake via pip instead of via jwlawson/actions-setup-cmake |
Member
can you do this please? will be better to keep the os matrix similar |
Contributor
Author
Got it! Just needs a rerun. |
mehermvr
reviewed
Nov 14, 2025
mehermvr
approved these changes
Nov 14, 2025
Member
|
@saurabh1002 lgtm, can you have a look at this as well. I also notice the action versions are out of date, which should probably also be updated (in a separate pr) |
Member
|
@saurabh1002 have a look and merge here as well |
saurabh1002
approved these changes
Dec 3, 2025
benemer
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that github has free ARM runners figured it would make sense to add this. We commonly need this to support our use cases and have had to resort to building it from source instead since the package was not available through pip.
I tried adding C++ builder support too but it seems the CMake install step you are using does not properly support ARM and it installed the X86 version instead.