fix rosbags dataloader to match the latest rosbags version on pypi#488
Merged
saurabh1002 merged 2 commits intomainfrom Dec 3, 2025
Merged
fix rosbags dataloader to match the latest rosbags version on pypi#488saurabh1002 merged 2 commits intomainfrom
saurabh1002 merged 2 commits intomainfrom
Conversation
saurabh1002
requested review from
benemer,
mehermvr,
nachovizzo and
tizianoGuadagnino
as code owners
mehermvr
previously approved these changes
Dec 2, 2025
Member
|
Lgtm Not sure what the policy is with the version pinning on pyproject. But that also lgtm |
mehermvr
reviewed
Dec 2, 2025
Member
mehermvr
left a comment
mehermvr
left a comment
There was a problem hiding this comment.
Actually not lgtm. Minor concern
mehermvr
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had no restriction on rosbags version used within
rosbag.pyandpoint_cloud2.pyfiles in our dataloader. The latest versions of rosbags (>0.10.7) break the existing API inpoint_cloud2.py.This came up as an issue in KISS-SLAM by @omar-abdulaaty
A fix already existed, thanks to @mehermvr's RKO-LIO pipeline
This PR just applies that fix to relevant files in KISS-ICP. It has also been tested on several rosbag files, without any issues.
Also added
rosbagsas an optional dependency into thepyproject.tomlenforcing the version in case someone uses the rosbag dataloader.