Merged
Conversation
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…/proceed into ms2-github-workflow-with-db
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
anishsapkota
had a problem deploying
to
Research
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
OhKai
approved these changes
Jan 23, 2025
Comment on lines
+4
to
+9
| # push: | ||
| # branches: | ||
| # - main | ||
| # pull_request: | ||
| # branches: | ||
| # - main |
Contributor
There was a problem hiding this comment.
Should this file be deleted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable us to deploy MS with db.
Adjustments:
Compare the migrations between main branch and current
--> if no diff detected, create/reuse the db with name
proceed_db_<branch-name>_main--> if diff detected, check the migrations within branch
Compare the migrations within the branch
--> if diff detected in step 1 and no diff within branch, create/reuse the db with
proceed_db_<branch-name>--> if diff detected in step 1 and diff detected within branch, drop old db and create new one with same name as above
Extend the @OhKai 's preview deployment action : action-preview-cloudrun
Bump prisma version to 6.2.1 --> This was necessary to support prisma in alpine linux that we use for docker image
Adjusted e2e tests
Postgres removes xml schema definition before saving to db ( alternative: use TEXT datatype instead XML) --> corrected this issue in application layer by concatenating xml schema definition after fetching for db
minor bug fixes