Skip to content

[BrickSelect] consider all invalid form elements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeremy-seipelt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BrickSelect] consider all invalid form elements #17

jeremy-seipelt wants to merge 1 commit into from

Conversation

@jeremy-seipelt
Copy link
Contributor

@jeremy-seipelt jeremy-seipelt commented Nov 5, 2019

#15

@jeremy-seipelt jeremy-seipelt changed the title add jovans code snippet and fill native select with the form id [BrickSelect] consider all invalid form elements Nov 5, 2019
TitanNano
TitanNano suggested changes Nov 6, 2019
View reviewed changes
BrickSelect/index.js
this._processOptions();
this._nativeSelect.required = this.hasAttribute('required');

if (!!this.getAttribute('form')) {
Copy link
Contributor

@TitanNano TitanNano Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use hasAttribute here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TitanNano TitanNano TitanNano requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@opaldes opaldes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeremy-seipelt @TitanNano @opaldes