Skip to content

Test whether CATKE works with the baroclinic instability model#212

Open
glwagner wants to merge 3 commits intomainfrom
glw/catke-baro-instability
Open

Test whether CATKE works with the baroclinic instability model#212
glwagner wants to merge 3 commits intomainfrom
glw/catke-baro-instability

Conversation

@glwagner
Copy link
Collaborator

No description provided.

@glwagner
Copy link
Collaborator Author

glwagner commented May 12, 2025

A lot Some unrelated tests fail here.

@glwagner
Copy link
Collaborator Author

@wsmoses I believe thre will be a raising error from the latest commit

include_halos = true
rtol = sqrt(eps(Float64))
atol = 0
atol = 1e-16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with absolute tolerance is that you need to know the scale of the numbers you're dealing with, and when the reference is exactly 0 there's no generally meaningful scale, any number can be both quite far or very close depending on how you look at it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, was just seeing failures for really small numbers so wanted to get past that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Small" is relative to something, related to 0 any number can be anything 😁

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related to me, 1e-16 is huge 😢

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way not to have data with zeros? That'd make things easier

@wsmoses wsmoses force-pushed the glw/catke-baro-instability branch from f74970a to da61a92 Compare May 13, 2025 23:56
@giordano giordano force-pushed the glw/catke-baro-instability branch from da61a92 to b75b0bd Compare May 19, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants