fix: handle partial application of transforms in user-defined functions #5663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PRQL#5661. When a user defines a function that wraps a transform with fewer parameters than the transform requires (e.g., `let foo = a -> take a`), the missing parameters are now correctly propagated to the wrapper function. The bug was in `materialize_function`: when wrapping a partially-applied inner function, it incorrectly truncated `inner_closure.params`. The fix keeps params intact and adds substitute args that reference the wrapper's parameters. This enables patterns like: - `let top_n = n -> take n` - wrap transforms with fewer params - `let top_5 = top_n 5` - store fully-configured transforms - `(top_n 5 | add_const 42)` - compose partial applications 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5661.
let foo = a -> take a)The bug was in
materialize_function: when wrapping a partially-applied inner function, the code was incorrectly truncatinginner_closure.params. The fix keeps params intact and creates wrapper params with substitute argument expressions.Test plan
task prqlc:pull-requestpassestest_partial_application_of_transformvalidates the fixtake,derive,filter, composed pipelines🤖 Generated with Claude Code