Skip to content

1528: Scroll and adjust zoom level of zoom view with mouse wheel - #1532

Merged
rpeterman-gp merged 5 commits into
mainfrom
feat/1528-waveform-inspector-enable-mouse-wheel-scrolling
Sep 9, 2026
Merged

1528: Scroll and adjust zoom level of zoom view with mouse wheel#1532
rpeterman-gp merged 5 commits into
mainfrom
feat/1528-waveform-inspector-enable-mouse-wheel-scrolling

Conversation

@rpeterman-gp

Copy link
Copy Markdown
Contributor

Closes #1528

  • enable mouse wheel scrolling on zoom view
  • add wheel handler to adjust zoom level with scroll wheel + alt key
  • update zoom level scale calculations to always use powers of 2

@rpeterman-gp
rpeterman-gp requested a review from a team September 8, 2026 21:40
@rpeterman-gp rpeterman-gp self-assigned this Sep 8, 2026
Comment thread app/assets/stylesheets/shared/layout.scss
@brandonhundt

Copy link
Copy Markdown
Contributor

@rpeterman-gp When I scroll using alt + mousewheel when editing clips, it works perfectly.

However, when I scroll using alt + mousewheel in the Episode > Media Files waveform editor, the mousewheel still scrolls both the page and zooms the waveform (the page area exceeds the screen).

I suspect you might need to disable page scrolling when alt is pressed??

@rpeterman-gp
rpeterman-gp added this pull request to stack #1535 September 9, 2026 15:44
@rpeterman-gp

Copy link
Copy Markdown
Contributor Author

@rpeterman-gp When I scroll using alt + mousewheel when editing clips, it works perfectly.

However, when I scroll using alt + mousewheel in the Episode > Media Files waveform editor, the mousewheel still scrolls both the page and zooms the waveform (the page area exceeds the screen).

I suspect you might need to disable page scrolling when alt is pressed??

Good catch. Easy fix. Guess none of my waveform pages needed to scroll during development.

@brandonhundt brandonhundt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @rpeterman-gp Thank you!

@rpeterman-gp
rpeterman-gp force-pushed the feat/1528-waveform-inspector-enable-mouse-wheel-scrolling branch from 9e905e9 to f25b3d9 Compare September 9, 2026 17:05
@rpeterman-gp
rpeterman-gp merged commit d8f7010 into main Sep 9, 2026
3 checks passed
@rpeterman-gp
rpeterman-gp deleted the feat/1528-waveform-inspector-enable-mouse-wheel-scrolling branch September 9, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable mouse wheel scrolling

2 participants