Open
Conversation
- Add "type": "module" to package.json for native ESM support - Add .js extensions to all relative imports in lib/ and index.js - Add nested package.json files in test/ and dist/ with "type": "commonjs" to keep CJS test files and UMD bundle working - Replace esm package with Node 24's native require(esm) in test loader - Upgrade mocha 6 -> 11, replace nyc with c8, upgrade typescript 3 -> 5 - Remove deprecated esm, codecov, and mocha-lcov-reporter packages - Convert bin/wavefile.js to ESM imports - Update engines field to >=18 - Add coverage/ to .gitignore
- Upgrade rollup ^1.27.14 -> ^4.0.0 - Upgrade @rollup/plugin-commonjs ^11.0.0 -> ^29.0.0 - Upgrade @rollup/plugin-node-resolve ^6.0.0 -> ^16.0.0 - Replace @ampproject/rollup-plugin-closure-compiler with @rollup/plugin-terser - Remove ES3 class check from test loader (no longer transpiling to ES3) - Bundle build time reduced from ~4.5s to ~450ms
- Remove externs/ directory (only used by Google Closure Compiler) - Remove scripts/polyfills.js (IE10 Uint8Array.slice polyfill, no longer injected) - Remove references to externs and scripts from package.json directories, files, and lint script
These configs tested against Node 8/9/10/12, which are all EOL. Travis CI free tier for open source is also discontinued.
jsdoc 3.x depended on taffydb which has a known data access vulnerability (GHSA-mxhp-79qh-mcx6). jsdoc 4.x drops this dependency. Reduces npm audit vulnerabilities from 8 to 6.
Matches the modern ES syntax now used in the project.
docdash 1.x depended on taffydb (via jsdoc 3.x). Since jsdoc was upgraded to 4.x which dropped taffydb, docdash needed to be upgraded to 2.x which uses @jsdoc/salty instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So many upgrades!
Node 24 related updates:
lib/wavefile-cue-editor.js, lib/mpeg-reader.js, lib/riff-file.js, lib/resampler/index.js, lib/parsers/binary/index.js, lib/parsers/write-string.js
test/loader.js — removed esm package, uses Node 24's native require(esm) support
test/dist/from-scratch/12bit-from-scratch.js — removed esm usage for byte-data
bin/wavefile.js — converted to ESM imports (uses dist/wrapper.mjs)
Rollup upgrade from 1 -> 4
Miscellaneous Clean-up!
Dead files from closure compiler removal:
Outdated CI configs:
Vulnerability fixes:
Minor: