Skip to content

Fix consumption tax revenue calculation #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+26 −4
Open

Fix consumption tax revenue calculation #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8587e6e
use c_i in cons tax liab calcs
jdebacker Nov 18, 2025
a39dc51
format
jdebacker Nov 18, 2025
f73e49f
bump version
jdebacker Nov 18, 2025
de7ede3
Merge remote-tracking branch 'upstream/master' into ci
jdebacker Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.14.12] - 2025-11-18 12:00:00

### Bug Fix

- Fix calculation of consumption tax revenue with differentiated goods ((PR #1074)[https://github.com/PSLmodels/OG-Core/pull/1074])

## [0.14.12] - 2025-11-07 12:00:00

Expand Down Expand Up @@ -465,6 +470,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Any earlier versions of OG-USA can be found in the [`OG-Core`](https://github.com/PSLmodels/OG-Core) repository [release history](https://github.com/PSLmodels/OG-Core/releases) from [v.0.6.4](https://github.com/PSLmodels/OG-Core/releases/tag/v0.6.4) (Jul. 20, 2021) or earlier.


[0.14.13]: https://github.com/PSLmodels/OG-Core/compare/v0.14.12...v0.14.13
[0.14.12]: https://github.com/PSLmodels/OG-Core/compare/v0.14.11...v0.14.12
[0.14.11]: https://github.com/PSLmodels/OG-Core/compare/v0.14.10...v0.14.11
[0.14.10]: https://github.com/PSLmodels/OG-Core/compare/v0.14.9...v0.14.10
Expand Down
10 changes: 9 additions & 1 deletion ogcore/SS.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,15 @@ def SS_solver(
np.squeeze(p.e[-1, :, :]),
p,
)
sales_tax_ss = tax.cons_tax_liab(cssmat, p_i_ss, p, "SS")
c_i = household.get_ci(
cssmat,
p_i_ss,
p_tilde_ss,
p.tau_c[-1, :],
p.alpha_c,
"SS",
)
sales_tax_ss = tax.cons_tax_liab(c_i, p_i_ss, p, "SS")
yss_before_tax_mat = household.get_y(
r_p_ss, wss, bssmat_s, nssmat, p, "SS"
)
Expand Down
10 changes: 9 additions & 1 deletion ogcore/TPI.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,15 @@ def run_TPI(p, client=None):
p.e,
p,
)
sales_tax_mat = tax.cons_tax_liab(c_mat, p_i, p, "TPI")
c_i = household.get_ci(
c_mat[: p.T, :, :],
p_i[: p.T, :],
p_tilde[: p.T],
p.tau_c[: p.T, :],
p.alpha_c,
"TPI",
)
sales_tax_mat = tax.cons_tax_liab(c_i, p_i, p, "TPI")
C = aggr.get_C(c_mat, p, "TPI")

c_i = household.get_ci(
Expand Down
2 changes: 1 addition & 1 deletion ogcore/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
from ogcore.txfunc import *
from ogcore.utils import *

__version__ = "0.14.12"
__version__ = "0.14.13"
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="ogcore",
version="0.14.12",
version="0.14.13",
author="Jason DeBacker and Richard W. Evans",
license="CC0 1.0 Universal (CC0 1.0) Public Domain Dedication",
description="A general equilibrium overlapping generations model for fiscal policy analysis",
Expand Down
Loading