Skip to content

Conversation

Copy link
Contributor

Copilot AI commented May 29, 2025

Summary

This PR updates the README to clearly specify the PowerShell version requirement and distinguish modern PowerShell from the legacy Windows PowerShell. It also enhances readability by converting the Prerequisites section into a bulleted list and adds installation links for PowerShell.

  • Explicit requirement for modern PowerShell (latest LTS version) is now included.
  • Clarification that Windows PowerShell is not supported.
  • Installation guides for PowerShell are provided, and the module dependency on Fonts is clarified.

Background

Windows 11 ships with Windows PowerShell (legacy) by default, but this module requires the modern cross-platform PowerShell. The previous README didn't specify which version was needed, potentially causing confusion for users.

Fixes #39.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] 🩹 [Patch]: Update readme to specify version of PowerShell that we support. 🩹 [Patch]: Update README to specify PowerShell 7+ requirement and distinguish from Windows PowerShell May 29, 2025
Copilot AI requested a review from MariusStorhaug May 29, 2025 15:48
@MariusStorhaug
Copy link
Member

Actually, lets make it more general and point to https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell

Copy link
Contributor Author

Copilot AI commented May 29, 2025

Actually, lets make it more general and point to https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell

Updated the PowerShell installation link to point to the Microsoft Learn documentation as requested. (d157182)

@MariusStorhaug
Copy link
Member

Lets also not point to version 7. Lets point to this not being Windows PowerShell, but "the latest version of PowerShell (not Windows PowerShell)".

Copy link
Contributor Author

Copilot AI commented May 29, 2025

Lets also not point to version 7. Lets point to this not being Windows PowerShell, but "the latest version of PowerShell (not Windows PowerShell)".

Updated the PowerShell requirement to be more general as requested. Changed from "PowerShell 7.0 or higher" to "the latest version of PowerShell (not Windows PowerShell)" and simplified the description. (a8458df)

@MariusStorhaug
Copy link
Member

Lets add also some more clarifying things:

Copy link
Contributor Author

Copilot AI commented May 29, 2025

Lets add also some more clarifying things:

Added the PowerShell overview link and cross-platform support information as requested. The Prerequisites section now includes a link to the PowerShell overview documentation and clarifies that this module supports PowerShell on Windows, Linux, and macOS. (9a7c041)

@MariusStorhaug MariusStorhaug marked this pull request as ready for review May 29, 2025 16:10
Copilot AI review requested due to automatic review settings May 29, 2025 16:10
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner May 29, 2025 16:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README to clearly specify the PowerShell version requirement and distinguish modern PowerShell from the legacy Windows PowerShell. It also enhances readability by converting the Prerequisites section into a bulleted list and adds installation links for PowerShell.

  • Explicit requirement for modern PowerShell (latest LTS version) is now included.
  • Clarification that Windows PowerShell is not supported.
  • Installation guides for PowerShell are provided, and the module dependency on Fonts is clarified.

@MariusStorhaug
Copy link
Member

From the linter:
/github/workspace/README.md:12:384 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Copy link
Contributor Author

Copilot AI commented May 29, 2025

From the linter:
/github/workspace/README.md:12:384 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Fixed the trailing space issue by removing the single trailing space from line 12 in README.md. The markdown linter now passes without errors. (746fb27)

@MariusStorhaug MariusStorhaug merged commit 920af2d into main May 29, 2025
34 checks passed
@MariusStorhaug MariusStorhaug deleted the copilot/fix-39 branch May 29, 2025 16:38
@github-actions
Copy link
Contributor

Module NerdFonts - 1.0.26 published to the PowerShell Gallery.

@github-actions
Copy link
Contributor

GitHub release for NerdFonts v1.0.26 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🩹 [Patch]: Update readme to specify version of PowerShell that we support.

2 participants