🩹 [Patch]: Use GitHub App again and some log and file formatting #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the GitHub workflow permissions and enhances the font update script by implementing GitHub App authentication and improving output formatting. The changes move from token-based authentication to GitHub App authentication while restructuring the script logic for better organization and clearer output.
Key changes:
- Replaces GitHub token permissions with GitHub App authentication using client ID and private key
- Restructures the PowerShell script with better logical grouping and enhanced output formatting
- Improves error handling and adds GitHub-specific output features like step summaries and notices
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/Update-FontsData.yml |
Removes explicit permissions and adds GitHub App credentials for authentication |
scripts/Update-FontsData.ps1 |
Enhances script with GitHub App connection, better output handling, and improved logical flow organization |
…rmat JSON output in Update-FontsData.ps1
MariusStorhaug
changed the title
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the workflow and script for automating the FontsData update process. Key changes include integration with GitHub App credentials, enhanced error handling, and formatting updates for better readability. The changes also streamline the process for detecting updates, committing changes, and creating pull requests.
Workflow updates:
.github/workflows/Update-FontsData.yml: Added GitHub App credentials (ClientIDandPrivateKey) for secure authentication during the update process. Removed permissions as these grant the GITHUB_TOKEN permissions, which is no longer used.Script enhancements:
scripts/Update-FontsData.ps1: Improved command execution to capture output and handle multiline results, returning formatted output when applicable.scripts/Update-FontsData.ps1: Updated JSON formatting forFontsData.jsonto include indentation for better readability.scripts/Update-FontsData.ps1: Enhanced logging and messaging, including clearer notices for no updates, summary of changes, and improved pull request titles and descriptions. [1] [2]Type of change
Checklist