Minor cleanup #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add integration_config.py template for API key configuration - Create test_live_api.py with basic connectivity tests and fixtures - Add conftest.py for integration test pytest configuration - Update .gitignore to exclude integration_config.py 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Move inline PDF content from test_live_api.py to separate file to improve code readability and fix long line issue. Also fix unused variable warning. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
13 tasks
msch-nutrient
added a commit
that referenced
this pull request
Jun 23, 2025
* feat: add split_pdf method for PDF document splitting - Add split_pdf method to DirectAPIMixin with flexible page range support - Support custom page ranges with start/end parameters (0-based indexing) - Allow saving to multiple output files or returning bytes list - Include comprehensive integration tests with live API verification - Update documentation and remove PDF splitting from limitations - Add implementation patterns to CLAUDE.md for future tool development 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * test: improve split_pdf integration tests with PDF validation - Add assert_is_pdf helper to validate output files are valid PDFs - Update tests to expect exactly 2 parts from multi-page sample PDF - Remove conditional checks since sample PDF now guaranteed to have multiple pages - Add PDF magic number validation for both bytes and file outputs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix: address linting issues in integration tests - Fix trailing whitespace and line length issues - Improve docstring formatting in assert_is_pdf helper 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix: resolve mypy type checking errors in integration tests - Add proper type annotations to assert_is_pdf function - Use !r format specifier for bytes to fix str-bytes-safe warning - Fix import ordering to satisfy ruff 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix: format code with ruff formatter - Apply ruff formatting to resolve CI format check failures 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.