Skip to content

nextjs: simplify check in useEffect #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
divyanshu013 merged 1 commit into from
Jan 23, 2025
Merged

nextjs: simplify check in useEffect #3

divyanshu013 merged 1 commit into from
Jan 23, 2025

Conversation

@divyanshu013
Copy link
Member

@divyanshu013 divyanshu013 commented Jan 23, 2025

  • Remove check for undefined
  • Change the cleanup function to not return anything (in-line with useEffect typing)

@divyanshu013 divyanshu013 requested a review from a team January 23, 2025 13:14
@divyanshu013 divyanshu013 self-assigned this Jan 23, 2025
@divyanshu013 divyanshu013 merged commit f0fdd72 into main Jan 23, 2025
3 checks passed
@divyanshu013 divyanshu013 deleted the div/nextjs-update branch January 23, 2025 14:37
miguelcalderon pushed a commit that referenced this pull request Jul 28, 2025
@divyanshu013
nextjs: simplify check in useEffect (#3)
2ebd09a 
- Remove check for undefined
- Change the cleanup function to not return anything (in-line with useEffect typing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritz078 ritz078 ritz078 approved these changes

Assignees

@divyanshu013 divyanshu013

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@divyanshu013 @ritz078