Skip to content

Added support for deleted objects #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FriedrichWeinmann merged 2 commits into from
Jan 23, 2025
Merged

Added support for deleted objects #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a00e0b0
Added support for deleted objects
FriedrichWeinmann Jan 22, 2025
84dffe3
added insufficient access scenario
FriedrichWeinmann Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ADSec/ADSec.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
RootModule = 'ADSec.psm1'

# Version number of this module.
ModuleVersion = '1.0.1'
ModuleVersion = '1.0.4'

# ID used to uniquely identify this module
GUID = '1cfaca0a-3c7d-47dd-bb9f-9711310a0b9d'
Expand All @@ -26,7 +26,7 @@
# Modules that must be imported into the global environment prior to importing
# this module
RequiredModules = @(
@{ ModuleName='PSFramework'; ModuleVersion='1.0.35' }
@{ ModuleName='PSFramework'; ModuleVersion='1.12.346' }
)

# Assemblies that must be loaded prior to importing this module
Expand Down
6 changes: 6 additions & 0 deletions ADSec/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.0.4 (2025-01-22)

- Upd: Raised PSFramework Dependency Version to 1.12.346
- Upd: Get-AdsAcl - Enabled retrieving ACL from deleted objects
- Upd: Get-AdsAcl - Detect insufficient access rights to retrieve security information

## 1.0.1 (2022-04-04)

- New: Configuration setting to disable connection verification
Expand Down
1 change: 1 addition & 0 deletions ADSec/en-us/strings.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
'Enable-AdsInheritance.Processing' = 'Starting process to enable inheritance on {0}' # $pathItem
'Enable-AdsInheritance.ReadAcl.Failed' = 'Failed to access acl on {0}' # $pathItem
'Enable-AdsInheritance.Updating.Acl' = 'Enabling inheritance' #
'Get-AdsAcl.NoSecurityProperty' = 'No security information found on {0}. Ensure you have sufficient access.' # $pathItem
'Get-AdsAcl.ObjectError' = 'Error accessing item: {0}' # $pathItem
'Get-AdsAcl.Processing' = 'Retrieving Acl from {0}' # $pathItem
'Get-AdsOrphanAce.Read.Failed' = 'Failed to access {0}' # $pathItem
Expand Down
20 changes: 10 additions & 10 deletions ADSec/functions/acl/Get-AdsAcl.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
function Get-AdsAcl
{
<#
function Get-AdsAcl {
<#
.SYNOPSIS
Reads the ACL from an AD object.

Expand Down Expand Up @@ -44,23 +43,24 @@
$EnableException
)

begin
{
begin {
$adParameters = $PSBoundParameters | ConvertTo-PSFHashtable -Include Server, Credential
Assert-ADConnection @adParameters -Cmdlet $PSCmdlet
}
process
{
process {
if (Test-PSFFunctionInterrupt) { return }

foreach ($pathItem in $Path)
{
foreach ($pathItem in $Path) {
if (-not $pathItem) { continue }
Write-PSFMessage -String 'Get-AdsAcl.Processing' -StringValues $pathItem

try { $adObject = Get-ADObject @adParameters -Identity $pathItem -Properties ntSecurityDescriptor }
try { $adObject = Get-ADObject @adParameters -Identity $pathItem -Properties ntSecurityDescriptor -IncludeDeletedObjects }
catch { Stop-PSFFunction -String 'Get-AdsAcl.ObjectError' -StringValues $pathItem -Target $pathItem -EnableException $EnableException -Cmdlet $PSCmdlet -ErrorRecord $_ -Continue }
$aclObject = $adObject.ntSecurityDescriptor
if (-not $aclObject) {
Stop-PSFFunction -String 'Get-AdsAcl.NoSecurityProperty' -StringValues $pathItem -Target $pathItem -EnableException $EnableException -Cmdlet $PSCmdlet -Category PermissionDenied -Continue
}

Add-Member -InputObject $aclObject -MemberType NoteProperty -Name DistinguishedName -Value $adObject.DistinguishedName -Force
$aclObject
}
Expand Down