feat: Add a ReusableMap that allows reusing the map allocation #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pair of new public types:
ReusableMapandBorrowedMap.Reusable map stores an ObjectAsVec and provides a
deserializemethod which returns aBorrowedMapthat uses unsafe to tie lifetimes to both the input json str reference and the deserializer.When the
BorrowedMapis dropped it runsclear()on the internalObjectAsVec, freeing it to be reused.Benches show a 4-15% increase in Avg and a 4-12% increase in median throughput compared to OwnedValue on my machine:
Actual improvement will depend a lot on the underlying shape of the data, especially how many nested objects there are. Now that this exists there's also a pattern in place, I could imagine storing a freelist of maps and vecs to reuse for nested objects that could probably squeeze out a bit more performance.