Skip to content

Conversation

@mmarchjr
Copy link

@mmarchjr mmarchjr commented Dec 9, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Changes

  • Removed the hard-coded TBA API key to avoid security issues
  • Added API variable in yearly config for teams to enter
  • Fixed miscellaneous typos in the documentation.
  • Updated documentation to reflect code changes

Description

A few changes fixing security vulnerabilities for The Blue Alliance by removing the hard-coded API key, and adding a variable in the configuration to replace it. The docs were also updated to reflect this change and to fix some minor typos.

@mmarchjr mmarchjr marked this pull request as ready for review December 9, 2025 03:10
Copilot AI review requested due to automatic review settings December 9, 2025 03:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a critical security issue by removing a hardcoded API key for The Blue Alliance and making it configurable through yearly config files. Additionally, it updates year references from 2020 to 2025 in HTML files and fixes several documentation typos and formatting issues.

Key Changes:

  • Removed hardcoded TBA API key from TBAInterface.js and added it as a configurable variable in all yearly config files
  • Updated year references from 2020 to 2025 in HTML page headers
  • Fixed spelling error "Auto Aquire" → "Auto Acquire" in 2020 config file
  • Improved documentation formatting and fixed typos in Configuration.md and README.md

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
resources/js/TBAInterface.js Removed hardcoded API key and fixed typo in comment ("funcitons" → "functions")
pit.html Updated year from 2020 to 2025 in page headers
index.html Updated year from 2020 to 2025 in pre-match, auton, and teleop page headers
docs/Configuration.md Improved markdown formatting with proper bullet points and spacing, removed trailing periods from section headers
archive/2024/crescendo_config.js Added configurable authKey variable with instructional comment
archive/2023/CU_config.js Added configurable authKey variable with instructional comment
archive/2023/CU_GS_config.js Added configurable authKey variable with instructional comment
archive/2022/RR_config.js Added configurable authKey variable with instructional comment
archive/2022/RR_GS_config.js Added configurable authKey variable with instructional comment
archive/2020/IR_config.js Added configurable authKey variable and fixed spelling error ("Aquire" → "Acquire")
README.md Updated documentation to reference config files for API key, improved markdown formatting, changed [TOC] marker, updated year references, and corrected line number reference
2025/reefscape_config.js Added configurable authKey variable with instructional comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant