[DRAFT] Backport semaphore fixes#188
Draft
ThomasDebrunner wants to merge 5 commits intopx4_firmware_nuttx-10.1.0+from
Draft
[DRAFT] Backport semaphore fixes#188ThomasDebrunner wants to merge 5 commits intopx4_firmware_nuttx-10.1.0+from
ThomasDebrunner wants to merge 5 commits intopx4_firmware_nuttx-10.1.0+from
Conversation
This reverts commit 24fe171.
Add a list in TCB to track all semphores the task held, so we can release all holders when exit, so nxsched_verify_tcb is unnecessary. Signed-off-by: Zeng Zhaoxiu <walker.zeng@transtekcorp.com>
Signed-off-by: Zeng Zhaoxiu <walker.zeng@transtekcorp.com>
1. The task which called nxsem_release_holder may not be a holder of the semaphore, counts of the holder would not be decreamented. This commit try to resolve the problem if there is only one holder. 2. Avoid counts overflow. Signed-off-by: Zeng Zhaoxiu <walker.zeng@transtekcorp.com>
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Contributor
|
There probably is a typo in summary. The priority inheritance PR is apache/nuttx#6318 |
Member
Author
|
Thanks, updated |
Member
|
@ThomasDebrunner Is this Additional change Needed as well? |
PX4BuildBot
pushed a commit
that referenced
this pull request
Aug 24, 2024
"net/netdev_upperhalf.c", line 133: warning #188-D: enumerated type mixed with another type total += netdev_lower_quota_load(lower, type); CC: dirent/lib_alphasort.c "spi/spi_transfer.c", line 83: warning #188-D: enumerated type mixed with another type SPI_SETMODE(spi, seq->mode); ^ Signed-off-by: guoshichao <guoshichao@xiaomi.com>
PX4BuildBot
pushed a commit
that referenced
this pull request
Aug 24, 2024
CC: irq/irq_initialize.c "ioexpander/gpio.c", line 386: warning #188-D: enumerated type mixed with another type *ptr = dev->gp_pintype; ^ Signed-off-by: guoshichao <guoshichao@xiaomi.com>
PX4BuildBot
pushed a commit
that referenced
this pull request
Aug 26, 2024
… warnings "/mnt/yang/qixinwei_cmake/nuttx/sched/sched/sched_removeblocked.c", line 58: warning #188-D: enumerated type mixed with another type tstate_t task_state = btcb->task_state; "/mnt/yang/qixinwei_cmake/nuttx/sched/sched/sched_setpriority.c", line 243: warning #188-D: enumerated type mixed with another type tstate_t task_state = tcb->task_state; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
PX4BuildBot
pushed a commit
that referenced
this pull request
Sep 19, 2024
CC: obstack/lib_obstack_printf.c "mmap/fs_rammap.c", line 126: warning #188-D: enumerated type mixed with another type enum mm_map_type_e type = (uintptr_t)entry->priv.p & 3; ^ Signed-off-by: guoshichao <guoshichao@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of apache/nuttx#5171 and draft apache/nuttx#6318
Impact
This should resolve priority inheritance issues
Testing
Tested against adverse example. Not flight tested.