Fix compile error, improve error message and docs#20
Fix compile error, improve error message and docs#20roland-ewald wants to merge 1 commit intoPacificBiosciences:developfrom
Conversation
This adds brief instructions on how to build the software (in particular, which flags need to be set to build it as an external user) to the README, and improves the error message that is printed when e.g. mm2helper->Align(...) is throwing an exception.
a992904 to
27cf253
Compare
|
These changes are important to me. I have BAMs that seemingly align correctly in |
|
@TedBrookings Would it help you if I uploaded the binary? (You should of course not trust me enough to run this outside a container 🥲, but I think I still have it somewhere, compiled on Ubuntu 24.04). |
|
@roland-ewald Thanks for the offer! I have a local branch that was ready to build, and your PR contained the fixes needed to get that built successful, so a binary is not necessary. That said, for the pipelines I'm running, I'm very wary of using a tool that can return success while incorrectly aligning no reads; and maintaining my own branch of |
|
We are no longer providing the source code here, but only provide static binaries; it's noted in the release notes. If you have problems with the tool and get |
|
There is no |
|
https://github.com/PacificBiosciences/pbmm2?tab=readme-ov-file#binary-availability points you to "Support", which has an issues tab. If you could break it down to a few reads that reproduce it, it would help. |
This adds brief instructions on how to build
pbmm2(in particular, which flags need to be set to build it as an external user) to the README, and improves the error message that is printed when e.g.mm2helper->Align(...)is throwing an exception.Two other points (raising them here as GitHub issues are not enabled for the project):
I've noticed that this builds version
1.13.1(not1.17.0); is there any way to build a newer version locally?Sometimes it is preferable to fail early when the aligner throws exceptions (e.g. because of invalid BAM tags). Right now these errors are printed out but the program continues and returns the non-error code
0. Maybe we could add a--strictoption to control this?