Skip to content

fix(catalog/ios): hide "Showing X of Y items" label when search overlay is active #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −7
Open

fix(catalog/ios): hide "Showing X of Y items" label when search overlay is active #1894

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7aaeb42
Initial plan
Copilot Mar 9, 2026
e0f6e54
fix: hide catalog ListHeaderComponent when iOS search overlay is active
Copilot Mar 9, 2026
c82f9b6
fix: keep ListHeaderComponent hidden until debounce clears after sear…
Copilot Mar 9, 2026
405c7e7
Fix header visibility to use debounced search state consistently
andrew-bierman Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions apps/expo/features/catalog/screens/CatalogItemsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,16 @@ function CatalogItemsScreen() {
</View>
}
ListHeaderComponent={
<View className="mb-4">
<View className="flex-row items-center justify-between">
<Text className="text-muted-foreground">{totalItemsText}</Text>
searchValue.length === 0 ? (
<View className="mb-4">
<View className="flex-row items-center justify-between">
<Text className="text-muted-foreground">{totalItemsText}</Text>
</View>
{paginatedItems.length > 0 && (
<Text className="mt-1 text-xs text-muted-foreground">{showingText}</Text>
)}
</View>
{paginatedItems.length > 0 && (
<Text className="mt-1 text-xs text-muted-foreground">{showingText}</Text>
)}
</View>
) : null
Comment on lines 199 to +209
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ListHeaderComponent is currently gated only on !isSearching, but isSearching is derived from the debounced search value. This means the header will still render while the iOS search overlay is active but the debounce hasn’t elapsed yet (e.g., immediately after typing or when the overlay is open with an empty query), which can reintroduce the “Showing X of Y items” label peeking/flicker. Consider also gating on the immediate searchValue (e.g., only show the header when both searchValue and debouncedSearchValue are empty) so the header hides immediately on search activation/typing and stays hidden until the debounce settles on clear.

Copilot uses AI. Check for mistakes.
}
ListEmptyComponent={
<View className="flex-1 items-center justify-center p-8">
Expand Down