Added support to ignore a pattern of files and to include a pattern of files#5
Merged
xocasdashdash merged 3 commits intomasterfrom Jul 22, 2025
Merged
Added support to ignore a pattern of files and to include a pattern of files#5xocasdashdash merged 3 commits intomasterfrom
xocasdashdash merged 3 commits intomasterfrom
Conversation
alecsammon
reviewed
Jul 22, 2025
alecsammon
left a comment
alecsammon
left a comment
There was a problem hiding this comment.
I'm still hoping that we still be able to get our changes merged upstream.
Can we
- Ensure that this is ready to merge upstream - i.e. has comments/documentation
- Open a separate PR into the upstream with the hope it might get merged?
- We can control which files from a directory should be ignored or included by using a regex pattern. - This is useful for cases where we want to ignore certain files (e.g., temporary files, logs) or include specific files (e.g., configuration files) based on their names or extensions.
xocasdashdash
force-pushed
the
add-a-regex-ignore
branch
from
e8fedb4 to
ee1753b
Compare
alecsammon
previously approved these changes
Jul 22, 2025
alecsammon
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to keep a single configuration in place for a repo where some of the files are overwritten and some are not.
For example, we could have some terraform code that we want to bootstrap once and then a different file that we want to always keep in sync. As long as this file has the "generated" in its name we can do this:
This should keep the configuration working for us.
Added an upstream PR BetaHuhn#360