[Optimize]Add norm_weights feature for topk_gating_softmax #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| } | ||
| int64_t tem_num_experts = num_experts; | ||
| if(bias != nullptr || apply_norm_weight) tem_num_experts = 0; | ||
| if(bias != nullptr) tem_num_experts = 0; |
There was a problem hiding this comment.
这里加一个注释，说明下，否则怪怪的，意思就是说当bias不空的时候，只走default逻辑
单测在上个PR里已增加 #3345 |
zhoutianzi666
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
功能支持
性能验证