Merge pull request #13949 from PaddlePaddle/wojtuss/unique-patterns-request-comment

luotao1 · web-flow · commit 7b11162ab5f6 · 2018-10-19T09:30:07.000+08:00
Added comment with request for enhancement
diff --git a/paddle/fluid/framework/ir/graph_pattern_detector.cc b/paddle/fluid/framework/ir/graph_pattern_detector.cc
@@ -259,6 +259,8 @@ GraphPatternDetector::DetectPatterns() {
   return result;
 }
 
+// TODO(Superjomn) enhance the function as it marks unique unique as duplicates
+// see https://github.com/PaddlePaddle/Paddle/issues/13550
 void GraphPatternDetector::UniquePatterns(
     std::vector<GraphPatternDetector::subgraph_t> *subgraphs) {
   if (subgraphs->empty()) return;

Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,8 @@ GraphPatternDetector::DetectPatterns() {`
`259`	`259`	`return result;`
`260`	`260`	`}`
`261`	`261`
	`262`	`+// TODO(Superjomn) enhance the function as it marks unique unique as duplicates`
	`263`	`+// see https://github.com/PaddlePaddle/Paddle/issues/13550`
`262`	`264`	`void GraphPatternDetector::UniquePatterns(`
`263`	`265`	`std::vector<GraphPatternDetector::subgraph_t> *subgraphs) {`
`264`	`266`	`if (subgraphs->empty()) return;`