[in progress] Expose API for parameter server by jacquesqiao · Pull Request #1039 · PaddlePaddle/Paddle

jacquesqiao · 2016-12-29T15:47:15Z

as comment of @reyoung, split this pr into two. one for pserver and one for swig.
1, PserverUtil #1051
2, swig api. TBD

reyoung

Please split this PR to 2 PRs.

First is Extract PServer Utils.

Second is Expose PServerUtils to SWIG.

reyoung · 2016-12-30T04:46:05Z

paddle/pserver/PServerUtil.h

+  void init();
+  void start();
+  void join();
+


DISABLE_COPY(PServerUtil);

reyoung · 2016-12-30T04:46:13Z

paddle/pserver/PServerUtil.h

+
+class PServerUtil {
+public:
+  void init();


init => 构造函数.

这里如果方便的话，可以考虑把GFLAGS提取出来，变成函数的参数。

好的，这里是这么想的，变成参数

reyoung · 2016-12-30T04:46:42Z

paddle/pserver/PServerUtil.h

+  void init();
+  void start();
+  void join();
+


析构的时候调用join.

reyoung · 2016-12-30T04:47:10Z

paddle/pserver/PServerUtil.h

+  void join();
+
+private:
+  std::vector<std::shared_ptr<ParameterServer2>> pservers_;


看起来，std::vector<std::unique_ptr< ParameterServer2 >> pservers_;
就够了

reyoung · 2016-12-30T04:50:54Z

paddle/pserver/ParameterServer2Main.cpp

-  for (auto& pserver : pservers) {
-    pserver->join();
-  }
+  PServerUtil* pserverUtil = new PServerUtil();


std::unique_ptr pservers(new PServerUtil());

把init实现在构造函数里，把join放到析构函数里的。

pservers->start();

reyoung · 2016-12-30T04:52:29Z

paddle/trainer/TrainerMain.cpp

-        }
-      }
-    }
+    PServerUtil* pserverUtil = new PServerUtil();


同上。这里new完了都没有delete。

如果不是必要，不要用C++的裸指针。

如果这个对象不会被多个对象使用，用unique_ptr
如果这个对象会被多个对象使用，用shared_ptr

好的，正在优化代码~~

wangkuiyi · 2017-01-01T23:28:31Z

paddle/pserver/PServerUtil.cpp

@@ -0,0 +1,77 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


Please refer to source file naming convention and rename this to be pserver_util.cpp.

wangkuiyi · 2017-01-01T23:28:45Z

paddle/pserver/PServerUtil.h

@@ -0,0 +1,33 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


Please refer to source file naming convention and rename this to be pserver_util.h.

好的，代码规范问题，会在分开的两个pr中进行，这个pr先关掉。

wangkuiyi · 2017-01-01T23:29:22Z

demo/quick_start/cluster/pserver.py

+
+from py_paddle import swig_paddle as api
+
+#import pudb;pudb.set_trace()


Please remove the unused line other than commenting it out.

ok，in progress

wangkuiyi · 2017-01-01T23:30:27Z

paddle/api/ParameterServer.cpp

@@ -0,0 +1,33 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


Please refer to source file naming convention and rename this to be parameter_server.cpp.

wangkuiyi · 2017-01-01T23:34:52Z

demo/quick_start/cluster/pserver.py

+def main():
+    api.initPaddle("--nics=lo0", "--port=7164", "--ports_num=1",
+                   "--num_gradient_servers=1", "--comment=paddle_pserver")
+    pserver = api.ParameterServer.createParameterServer()


我没有太看明白这里的API设计。我以为这里是想通过调用Python API启动一个parameter server process？

如果是，那么是不是应该把 L21到L26简化为，比如：

psid = api.pserver.start(nics="lo0", port=7164, ports_num=1, num_gradient_server=1, comment="paddle_pserver") api.pserver.wait(psid)

对，这个后面正在修改，目前长这个样子是因为历史遗留问题，initPaddle实际上是去初始化各种gflags，后面的版本已经改成proto配置了，见#1051

wangkuiyi · 2017-01-01T23:35:45Z

demo/quick_start/cluster/pserver.py

+def main():
+    api.initPaddle("--nics=lo0", "--port=7164", "--ports_num=1",
+                   "--num_gradient_servers=1", "--comment=paddle_pserver")
+    pserver = api.ParameterServer.createParameterServer()


Please follow Python code convention and rename module/package name ParameterServer to be pserver or parameter_server.

jacquesqiao added 5 commits December 27, 2016 11:50

add remote updater in api and swig

32b28c6

merge develop

8ff42cd

do not init localUpdater

647f9a0

udw nullptr as localUpdater

cee9944

add PserverUtil

8015171

jacquesqiao changed the title ~~Expose API for parameter server~~ [in progress] Expose API for parameter server Dec 29, 2016

add pserver.py that can work

eaf19f5

jacquesqiao requested a review from reyoung December 30, 2016 03:01

jacquesqiao self-assigned this Dec 30, 2016

reyoung requested changes Dec 30, 2016

View reviewed changes

wangkuiyi requested changes Jan 1, 2017

View reviewed changes

jacquesqiao mentioned this pull request Jan 3, 2017

Add ParameterServerController for parameter server python api #1051

Merged

jacquesqiao closed this Jan 3, 2017

lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024

add ppdet auto compression demo (PaddlePaddle#1039)

380bce6

		@@ -0,0 +1,77 @@
		/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.

		@@ -0,0 +1,33 @@
		/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


		from py_paddle import swig_paddle as api

		#import pudb;pudb.set_trace()

Conversation

jacquesqiao commented Dec 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reyoung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jacquesqiao commented Dec 29, 2016 •

edited

Loading