Skip to content

Conversation

17Skye17
Copy link

@17Skye17 17Skye17 commented Mar 2, 2017

keyword argument 'average_window' is not expected

keyword argument 'average_window' is not expected
@wangkuiyi wangkuiyi requested a review from pengli09 March 2, 2017 20:06
@wangkuiyi
Copy link
Collaborator

I noticed that in #905, @pengli09 removed the parameter average_window. Could @pengli09 please review this PR? Thanks!

batch_size=128,
learning_rate=2e-3,
learning_method=AdamOptimizer(),
average_window=0.5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed into model_average=ModelAverage(average_window=0.5),

@wangkuiyi
Copy link
Collaborator

我看 @17Skye17 在某个PR里已经把 average_window=0.5 这行删掉了。这里还需要按照 @pengli09建议 修改吗?还是这个PR可以关掉了?也请 @qingqing01 看看吧。

@qingqing01
Copy link
Contributor

@qingqing01
Copy link
Contributor

Close this PR, since it was fixed by #1882

@qingqing01 qingqing01 closed this Apr 25, 2017
lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants