Skip to content

Decrator for paddle.ones to support *size usage #74494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/paddle/tensor/creation.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import paddle
from paddle import _C_ops
from paddle.utils.decorator_utils import SizeArgsDecorator
from paddle.utils.inplace_utils import inplace_apis_in_dygraph_only

from ..base.data_feeder import (
Expand Down Expand Up @@ -1234,6 +1235,7 @@ def fill_constant(
return out


@SizeArgsDecorator()
def ones(
shape: ShapeLike, dtype: DTypeLike | None = None, name: str | None = None
) -> paddle.Tensor:
Expand Down
32 changes: 32 additions & 0 deletions python/paddle/utils/decorator_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,35 @@ def process(
f"Cannot specify both '{original}' and its alias '{alias}'"
)
return args, processed_kwargs


# *size => shape decorator
class SizeArgsDecorator(DecoratorBase[_P, _R]):
"""
Usage Example:
paddle.ones(1, dtype=paddle.float32)
paddle.ones(1, 2, 3, dtype=paddle.float32)
paddle.ones([1, 2, 3], dtype=paddle.float32)
paddle.ones(size=[1, 2, 3], dtype=paddle.float32)
paddle.ones([1, 2, 3], paddle.float32)
paddle.ones(shape=[1, 2, 3], dtype=paddle.float32)
"""

def process(
self, args: tuple[Any, ...], kwargs: dict[str, Any]
) -> tuple[tuple[Any, ...], dict[str, Any]]:
if 'size' in kwargs:
kwargs['shape'] = kwargs.pop('size')
elif len(args) >= 1:
is_all_int = True
for ele in args:
if not isinstance(ele, int):
is_all_int = False
break
if is_all_int:
kwargs['shape'] = list(args)
args = ()

return args, kwargs
101 changes: 92 additions & 9 deletions test/legacy_test/test_ones_op.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,38 +20,121 @@


class ApiOnesTest(unittest.TestCase):
def test_paddle_ones(self):
def test_static_ones(self):
paddle.enable_static()
with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(10, dtype=paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(10, 2, 3, dtype=paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones([10, 2, 3], dtype=paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(size=[10, 2, 3], dtype=paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones([10, 2, 3], paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones([10, 2, 3], paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(shape=[10, 2, 3], dtype=paddle.float32)
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(shape=[10])
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expected_result = np.ones(10, dtype="float32")
self.assertEqual((result == expected_result).all(), True)
expect = np.ones(10, dtype="float32")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(shape=[10], dtype="float64")
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expected_result = np.ones(10, dtype="float64")
self.assertEqual((result == expected_result).all(), True)
expect = np.ones(10, dtype="float64")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(shape=[10], dtype="int64")
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expected_result = np.ones(10, dtype="int64")
self.assertEqual((result == expected_result).all(), True)
expect = np.ones(10, dtype="int64")
np.testing.assert_equal(result, expect)

with paddle.static.program_guard(paddle.static.Program()):
ones = paddle.ones(shape=10, dtype="int64")
place = paddle.CPUPlace()
exe = paddle.static.Executor(place)
(result,) = exe.run(fetch_list=[ones])
expected_result = np.ones(10, dtype="int64")
self.assertEqual((result == expected_result).all(), True)
expect = np.ones(10, dtype="int64")
np.testing.assert_equal(result, expect)
paddle.disable_static()

def test_dygraph_ones(self):
paddle.disable_static()
result = paddle.ones(10, dtype=paddle.float32)
expect = np.ones([10], dtype="float32")
np.testing.assert_equal(result, expect)

result = paddle.ones(10, 2, 3, dtype=paddle.float32)
expect = np.ones([10, 2, 3], dtype="float32")
np.testing.assert_equal(result, expect)

result = paddle.ones([10, 2, 3], dtype=paddle.float32)
np.testing.assert_equal(result, expect)

result = paddle.ones(size=[10, 2, 3], dtype=paddle.float32)
np.testing.assert_equal(result, expect)

result = paddle.ones([10, 2, 3], paddle.float32)
np.testing.assert_equal(result, expect)

result = paddle.ones([10, 2, 3], "float32")
np.testing.assert_equal(result, expect)

result = paddle.ones(shape=[10, 2, 3], dtype=paddle.float32)
np.testing.assert_equal(result, expect)


if __name__ == "__main__":
Expand Down
Loading