[API] Support `zero_infinity` in `ctc_loss` #75742

aztice · 2025-10-11T08:59:17Z

PR Category

User Experience

PR Types

New features

Description

为 ctc_loss 添加 zero_infinity 参数

paddle-bot · 2025-10-11T08:59:22Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

aztice · 2025-10-11T09:10:24Z

/re-run all-failed

aztice · 2025-10-11T11:24:01Z

/re-run all-failed

aztice · 2025-10-11T13:15:05Z

Assert Diff Coverage
no data found
Assert Python Diff Coverage
expected >= 90.0 %, actual 50.0 %, failed
The title does not start with cinn or typing or codestyle or fluid_ops or 3.13
9
Coverage check failed, unit tests have all passed, please do not rerun, check whether the newly added code lines are fully covered by unit tests. If you have any questions, please contact XieYunshen.

看起来 CI 似乎是可以忽略的

aztice · 2025-10-11T13:51:26Z

/re-run all-failed

aztice · 2025-10-13T09:00:11Z

/re-run all-failed

aztice · 2025-10-13T10:36:15Z

@XiaoguangHu01
@SigureMo
两位Reviewer可以帮我review下吗，CI需要

codecov-commenter · 2025-10-13T11:45:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@f556d04). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #75742   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         4           
  Branches           ?         0           
===========================================
  Hits               ?         4           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

python/paddle/nn/functional/loss.py

zxcd · 2025-10-14T12:22:49Z

add new parameter also need to add it to test to pass Coverage CI.

aztice · 2025-10-15T08:58:33Z

/re-run all-failed

zxcd

LGTM

Refactor code for better readability by adjusting line breaks and formatting in test_warpctc_op.py.

Replaced the use of self.seed with a fixed seed value for consistency in tests.

test/legacy_test/test_warpctc_op.py

Refactored test to use paddle.enable_static() and removed context manager for static graph.

test/legacy_test/test_warpctc_op.py

Removed unused import of contextlib.

aztice · 2025-10-30T23:40:51Z

/re-run all-failed

test/legacy_test/test_warpctc_op.py

Co-authored-by: Nyakku Shigure <[email protected]>

aztice · 2025-10-31T03:42:08Z

/re-run all-failed

test/legacy_test/test_warpctc_op.py

SigureMo · 2025-10-31T09:29:26Z

我刚刚没注意，CTCLoss 的实现有问题吧？为什么新增参数 zero_infinity 是作为 forward 输入？torch 是 __init__ 的输入吧？？？

aztice · 2025-10-31T09:33:19Z

我刚刚没注意，CTCLoss 的实现有问题吧？为什么新增参数 zero_infinity 是作为 forward 输入？torch 是 __init__ 的输入吧？？？

稍等我看看

aztice · 2025-10-31T09:39:37Z

我刚刚没注意，CTCLoss 的实现有问题吧？为什么新增参数 zero_infinity 是作为 forward 输入？torch 是 __init__ 的输入吧？？？

确认了下，稍等我开个新PR改下，forward 以及 __init__ 均支持输入。

aztice · 2025-10-31T10:06:26Z

@SigureMo #76156
转这里

feat: ctc_loss.zero_infinity

eb6724f

paddle-bot bot added the contributor External developers label Oct 11, 2025

aztice added 2 commits October 11, 2025 17:02

fix: code-style issue.

48f9719

fix: code-style issue.

e6d76e0

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 11, 2025

luotao1 self-assigned this Oct 11, 2025

aztice changed the title ~~feat: ctc_loss.zero_infinity~~ fluid_ops/feat: support zero_infinity in ctc_loss Oct 13, 2025

luotao1 assigned zxcd Oct 14, 2025

zxcd reviewed Oct 14, 2025

View reviewed changes

python/paddle/nn/functional/loss.py Outdated Show resolved Hide resolved

aztice added 8 commits October 14, 2025 22:19

optimize: reduce calculation

e85ceb1

fix: code-style issue.

fbffc8b

feat: test_warpctc_zero_infinity

5179ca5

fix: code-style issue.

b37acdd

fix: code-style issue.

948b74e

fix: zero_infinity for ctc_loss

86f5315

fix: code-style issue.

417dc59

fix: code-style issue.

5d06635

aztice requested a review from zxcd October 15, 2025 08:59

zxcd approved these changes Oct 17, 2025

View reviewed changes

luotao1 assigned jeff41404 Oct 17, 2025

aztice requested review from SigureMo and jeff41404 October 30, 2025 12:49

aztice added 5 commits October 30, 2025 20:51

Format labels_np initialization for readability

2f0af5a

Refactor string literals and improve formatting

3f132ca

Improve code formatting in test_warpctc_op.py

6e0cc73

Refactor code for better readability by adjusting line breaks and formatting in test_warpctc_op.py.

Refactor static_graph context manager usage

6c7c51a

Use fixed seed value in static_graph context manager

fe2834a

Replaced the use of self.seed with a fixed seed value for consistency in tests.

SigureMo reviewed Oct 30, 2025

View reviewed changes

test/legacy_test/test_warpctc_op.py Outdated Show resolved Hide resolved

Refactor static graph usage in CTC loss test

0ca8eb1

Refactored test to use paddle.enable_static() and removed context manager for static graph.

SigureMo requested changes Oct 30, 2025

View reviewed changes

test/legacy_test/test_warpctc_op.py Show resolved Hide resolved

aztice added 3 commits October 31, 2025 07:26

Refactor CTC loss test to use program guard

a49b6bc

Remove unused import in test_warpctc_op.py

7b7decb

Removed unused import of contextlib.

Enable and disable static mode in warpctc test

4912b43

SigureMo requested changes Oct 31, 2025

View reviewed changes

test/legacy_test/test_warpctc_op.py Outdated Show resolved Hide resolved

SigureMo reviewed Oct 31, 2025

View reviewed changes

test/legacy_test/test_warpctc_op.py Outdated Show resolved Hide resolved

aztice and others added 2 commits October 31, 2025 11:33

Update test/legacy_test/test_warpctc_op.py

f2b9f30

Co-authored-by: Nyakku Shigure <[email protected]>

Replace assertTrue with assert_allclose in tests

66a8efd

aztice requested a review from SigureMo October 31, 2025 03:42

SigureMo reviewed Oct 31, 2025

View reviewed changes

test/legacy_test/test_warpctc_op.py Outdated Show resolved Hide resolved

Update test/legacy_test/test_warpctc_op.py

53b643e

SigureMo approved these changes Oct 31, 2025

View reviewed changes

SigureMo merged commit 8036231 into PaddlePaddle:develop Oct 31, 2025
102 of 106 checks passed

aztice deleted the 1e30 branch October 31, 2025 09:24

SigureMo mentioned this pull request Oct 31, 2025

[API] Move the zero_infinity parameter of CTCLoss from the forward function to the constructor #76156

Merged

[API] Support zero_infinity in ctc_loss #75742

[API] Support zero_infinity in ctc_loss #75742

Uh oh!

Conversation

aztice commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Oct 11, 2025

Uh oh!

aztice commented Oct 11, 2025

Uh oh!

aztice commented Oct 11, 2025

Uh oh!

aztice commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aztice commented Oct 11, 2025

Uh oh!

aztice commented Oct 13, 2025

Uh oh!

aztice commented Oct 13, 2025

Uh oh!

codecov-commenter commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zxcd commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aztice commented Oct 15, 2025

Uh oh!

zxcd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aztice commented Oct 30, 2025

Uh oh!

Uh oh!

Uh oh!

aztice commented Oct 31, 2025

Uh oh!

Uh oh!

Uh oh!

SigureMo commented Oct 31, 2025

Uh oh!

aztice commented Oct 31, 2025

Uh oh!

aztice commented Oct 31, 2025

Uh oh!

aztice commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[API] Support `zero_infinity` in `ctc_loss` #75742

[API] Support `zero_infinity` in `ctc_loss` #75742

aztice commented Oct 11, 2025 •

edited

Loading

aztice commented Oct 11, 2025 •

edited

Loading

codecov-commenter commented Oct 13, 2025 •

edited

Loading

zxcd commented Oct 14, 2025 •

edited

Loading