Skip to content

Remove do_average_in_cpu, max_average_window, average_window from optimizers.py #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Remove do_average_in_cpu, max_average_window, average_window from optimizers.py #905

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8455071
Remove do_average_in_cpu, max_average_window, average_window from opt…
Dec 15, 2016
6516fd9
Fix formatting error.
Dec 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions python/paddle/trainer_config_helpers/optimizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,6 @@ def settings(batch_size,
learning_rate_decay_b=0.,
learning_rate_schedule='poly',
learning_rate_args='',
average_window=0,
do_average_in_cpu=False,
max_average_window=None,
learning_method=None,
regularization=None,
is_async=False,
Expand Down Expand Up @@ -412,7 +409,6 @@ def settings(batch_size,
args = [
'batch_size', 'learning_rate', 'learning_rate_decay_a',
'learning_rate_decay_b', 'learning_rate_schedule', 'learning_rate_args',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来，这里多了个,
所以导致Paddle格式检查不过。

目前paddle使用pre-commit来做格式检查。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

'average_window', 'do_average_in_cpu', 'max_average_window'
]
kwargs = dict()
kwargs['algorithm'] = algorithm
Expand Down