Fixed model export logging + moved test data directory #1626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logging during model exporting jobs (
paddle2onnx/mapper/exporter.cc), particularly for when a model is not supported yet. There were many lines of code that should have logged important information in case of model conversion failure, but actually printed nothing. This should help with debugging and expanding support for new models in the future.Output for an unsupported model before this change:
Example output for an unsupported model after this change:
Additionally, this PR also changes the test data directory. Prior to this change, running tests locally creates many folders and files in the root directory, resulting in a lot of clutter. Instead, tests now create temp files under
<project root>/test_data/