Skip to content

Make sharding_first by default#2822

Merged
lugimzzz merged 1 commit intoPaddlePaddle:developfrom
sneaxiy:make_sharding_first_by_default
Nov 3, 2025
Merged

Make sharding_first by default#2822
lugimzzz merged 1 commit intoPaddlePaddle:developfrom
sneaxiy:make_sharding_first_by_default

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Oct 30, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

Make sharding_first by default. Cherry-pick PaddlePaddle/PaddleNLP#11059.

@paddle-bot
Copy link

paddle-bot bot commented Oct 30, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@38c47d4). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2822   +/-   ##
==========================================
  Coverage           ?   28.80%           
==========================================
  Files              ?      335           
  Lines              ?    56425           
  Branches           ?        0           
==========================================
  Hits               ?    16251           
  Misses             ?    40174           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lugimzzz lugimzzz merged commit 5210ec0 into PaddlePaddle:develop Nov 3, 2025
11 of 17 checks passed
@sneaxiy sneaxiy deleted the make_sharding_first_by_default branch November 3, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants