Skip to content

Couple UX improvements #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Couple UX improvements #8

wants to merge 2 commits into from

Conversation

avargaskun
Copy link

iOS

  • Wait until dialog is dismissed before sending result back to Cordova app. Without this, certain UI elements that are shown as part of the callback end up being hidden along with the dialog as it gets closed by the OS.

Android

  • Request focus on the text-editor field in the dialog, which brings up the soft-keyboard after opening the dialog. iOS already behaves this way (no fix needed)

@avargaskun
Auto-focus and open soft-keyboard on Android
2de1693 
- On iOS the keyboard is displayed automatically when the dialog is shown
- This change makes it work the same way on Android
@avargaskun
Wait for dialog dismissal before sending result
3ad37ab 
- Do not callback into the Cordova application until dialog is dismissed
- Otherwise, UI elements shown after the callback get dismissed along with the dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@avargaskun