Skip to content

Adding requests and limits to Konnector jobs #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yishaynaPalo merged 2 commits into from
Jan 4, 2026
Merged

Adding requests and limits to Konnector jobs #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae1ff82
Adding resources and limits to Konnector jobs
oded7hoffman Jan 2, 2026
158d0f7
Reduce cleanup job cpu request
oded7hoffman Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/konnector/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: konnector
description: Deploys Palo Alto Networks' Cortex KSPM connector for advanced Kubernetes security posture management.
type: application
version: 1.0.24-rc.4
version: 1.0.24-rc.5
appVersion: "1.0.0"
maintainers:
- name: Palo Alto Networks - Cortex KSPM team
Expand Down
2 changes: 2 additions & 0 deletions charts/konnector/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ spec:
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}/{{ .Values.image.name }}{{- if .Values.image.tag }}:{{ .Values.image.tag }}{{- end }}{{- if .Values.image.digest }}@{{ .Values.image.digest }}{{- end }}"
resources:
{{- toYaml .Values.system.apps.resources | nindent 12 }}
command: [/{{ .Chart.Name }}]
env:
- name: NAMESPACE
Expand Down
2 changes: 2 additions & 0 deletions charts/konnector/templates/batch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ spec:
containers:
- name: helm-uninstall
image: alpine/helm:3.17.2
resources:
{{- toYaml .Values.system.batch.cleanupJob.resources | nindent 12 }}
command: ["/bin/sh", "-c"]
args:
- |
Expand Down
15 changes: 15 additions & 0 deletions charts/konnector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ system:
batch:
backoffLimit: 4 # Maximum number of retries before the job is considered failed. After 4 attempts, the job will fail.
ttlSecondsAfterFinished: 3600 # Time-to-live for completed jobs, jobs will be automatically deleted 3600 seconds (1 hour) after completion
cleanupJob:
Copy link

@nwolfin nwolfin Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to think about the backOffLimit and the ttlinSeconds? isn't it related to cleaning up jobs ?

Copy link
Contributor Author

@oded7hoffman oded7hoffman Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwolfin This is for the installer konnector job, not the cleanup job. And I don't think we need backOffLimit for it. (Currently, we remove it once it's finished, so ttlSecondsAfterFinished doesn't make any sense.)

resources:
requests:
cpu: 10m
memory: 50Mi
limits:
cpu: 150m
memory: 200Mi

# ==========================
# Service Account Resources
Expand Down Expand Up @@ -236,6 +244,13 @@ system:
# Apps Configurations
# ==========================
apps:
resources:
requests:
cpu: 50m
memory: 50Mi
limits:
cpu: 150m
memory: 200Mi
tolerations:
- key: "kubernetes.io/arch"
operator: "Equal"
Expand Down