Skip to content

Conversation

@dsuket
Copy link
Contributor

@dsuket dsuket commented Nov 18, 2025

Description

  • I implemented internationalization for QualifierMessage.
  • I moved the output of QualifierMessage from the plugin to the theme side.
    • Along with this change, I removed unnecessary methods from the plugin.
  • Added the ja resource file.
  • Fix snapshot

Motivation and Context

The QualifierMessage was not internationalized, so I fixed it.

How Has This Been Tested?

  • Updated and executed the tests.
  • I ran it locally and checked.

Screenshots (if appropriate)

スクリーンショット 2025-11-18 9 21 43

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@dsuket dsuket marked this pull request as ready for review November 18, 2025 00:27
@dsuket dsuket force-pushed the translate-QualifierMessage branch from 5b027a6 to b6afb5e Compare November 18, 2025 00:32
@dsuket dsuket changed the title translate QualifierMessage Translate qualifierMessage Nov 18, 2025
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit b6afb5e):

https://docusaurus-openapi-36b86--pr1249-5y63xwne.web.app

(expires Thu, 15 Jan 2026 22:20:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata
Copy link
Member

Thanks @dsuket! The i18n approach looks solid — moving translatable strings from the plugin to the theme is the right move.

Questions before merging:

  • Demo config change — Adding i18n: { locales: ["en", "ja"] } enables multi-locale builds for the demo site. Is this intentional going forward, or was it just for testing? If just for testing, please remove it. If intentional, please document why in the PR description.
  • String coverage — Are all hardcoded strings in getQualifierMessage now translatable? (e.g., "non-empty", ">= X characters", "Value must match regular expression")
  • Plugin export — Is getQualifierMessage still exported from the plugin for backward compatibility, or is it being removed? Should we flag it for future cleanup?

@sserrata sserrata self-assigned this Dec 17, 2025
@sserrata sserrata added the reviewing 👀 Undergoing manual audit to determine if issue should still be active label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewing 👀 Undergoing manual audit to determine if issue should still be active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants