Fixes #463. Expose LLDP neighbors on EthernetInterface#464
Open
DavidVentura wants to merge 1 commit intoPaloAltoNetworks:developfrom
Open
Fixes #463. Expose LLDP neighbors on EthernetInterface#464DavidVentura wants to merge 1 commit intoPaloAltoNetworks:developfrom
DavidVentura wants to merge 1 commit intoPaloAltoNetworks:developfrom
Conversation
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
shinmog
reviewed
Oct 23, 2022
Collaborator
shinmog
left a comment
shinmog
left a comment
There was a problem hiding this comment.
Does this feel like it should be in an opstate namespace...?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new function:
get_lldp_neighborstoEthernetInterface, which returns a list of LLDP neighbors from the device.Motivation and Context
LLDP is very useful to determine whether patching was carried out correctly, see #463
How Has This Been Tested?
I am testing this on a PA-850.
Lint rules from the contributing guidelines were broken prior to this change
Types of changes
Checklist
I have not added tests, I couldn't find a test for
get_countersto base my test on, is there a similar test I can use as an example?