fix(client): Fix logic on config locks + change funcs name for more obvious #113
Open
pimielowski wants to merge 7 commits intoPaloAltoNetworks:mainfrom
Open
fix(client): Fix logic on config locks + change funcs name for more obvious #113pimielowski wants to merge 7 commits intoPaloAltoNetworks:mainfrom
pimielowski wants to merge 7 commits intoPaloAltoNetworks:mainfrom
Conversation
Improve validation option in Panorama
add push validation
Fix logic choosing correct schema for PANOS versions
pimielowski
changed the title
pimielowski
changed the title
4 tasks
pimielowski
changed the title
sebastianczech
suggested changes
Nov 20, 2023
sebastianczech
left a comment
sebastianczech
left a comment
There was a problem hiding this comment.
Is this PR duplication of #111 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix logic choosing correct schema for PANOS versions
Motivation and Context
Name of the function was little confuse.
There was a issue with choosing correct schema based on the PANOS version
How Has This Been Tested?
go test -v ./...+ using local codeTypes of changes
Checklist