Update splunk_sdk.py - Bug Fix for Multiple Credentials in Splunk Cred Store #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some error checking and a continue statement to generate_configs function. In the event that the Splunk server has multiple credential stores, this won't cause the script to break. Added minor debug logging.
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
This was referenced Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
splunk_skd.py doesn't handle errors related to the "generate_config" function or log well, added a few tweaks to assist with the and troubleshooting.
Motivation and Context
Splunk Environments with multiple credential stores / TA-s using the credential store will break the "generate_config" function. Loop required the addition of a "continue" statement to work using multiple entries.
How Has This Been Tested?
This correction has been running in a production environment for ~ 8 months with no issues.
Screenshots (if appropriate)
N/A
Types of changes
Checklist