refact: support secrets from env vars and include vault namespace header#45
Merged
refact: support secrets from env vars and include vault namespace header#45
Conversation
v-rocheleau
commented
Oct 16, 2025
app/permissions_engine/vault.rego
Outdated
|
|
||
| else := "opa" | ||
|
|
||
| # TODO: need to pass the 'X-Vault-Namespace' header to the vault requests |
Contributor
Author
There was a problem hiding this comment.
Not super familiar with rego, so I would like to know your opinion on the best way to do this @daisieh .
The name of the Vault namespace will be set as an environment variable VAULT_NAMESPACE in the container.
When the env var is present, we simply need to add its value in the X-Vault-Namespace header.
Contributor
Author
|
Will fix the tests soon |
daisieh
approved these changes
Nov 13, 2025
Contributor
daisieh
left a comment
daisieh
left a comment
There was a problem hiding this comment.
I fixed all of the permissions-engine instances to permissions_engine and everything seems to work now. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the deployment of
pcgl-authzon KubernetesProblems:
/appfor the API and the OPA sidecar erases the files built in the image at that path, breaking the Flask APIpcgl-authzwill not use the root Vault namespace, it needs to use a specific namespace that is managed for it. Every request made to Vault must specify the namespacepcgl-authzmust not unseal the Vault serverSolutions:
/permissions_enginein the containers, copied/modified from/app/permissions_enginepresent in the image. This prevents erasing application files at/app.VAULT_NAMESPACEenvironment variable whose value is added to theX-Vault-Namespaceheader (if provided), along withX-Vault-Tokendev.entrypoint.sh) and k8s deployment without unseal (entrypoint.sh).