Conversation
🦋 Changeset detectedLatest commit: 0424253 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@iosh cc |
|
The test failed. I'll check it later |
|
@iosh it's the |
Yes, you're right, The |
|
@iosh Maybe we could remain the home command and move the |
I think we can either remove the command now or add a warning first and remove it later. |
|
@iosh Now I realise the The warning disappear and no harm to the feature. |
|
I think we can stop write export async function onUse(name: string) {
const registries = await getRegistries();
let alias = name;
// if alias is undefined, select the registry alias from list
if (alias === undefined) {
alias = await select<string>({
message: 'Please select the registry you want to use',
choices: Object.keys(registries),
pageSize: 10,
});
}
if (await isRegistryNotFound(alias)) {
return;
}
const registry = registries[alias];
const npmrc = await readFile(NPMRC);
await writeFile(NPMRC, Object.assign(npmrc, registry));
printSuccess(`The registry has been changed to '${alias}'.`);
}export async function onUse(name: string) {
// ...
// Don't write the`home` to .npmrc
const {home:_, ...registry} = registries[alias];
const npmrc = await readFile(NPMRC);
await writeFile(NPMRC, Object.assign(npmrc, registry));
printSuccess(`The registry has been changed to '${alias}'.`);
} |
|
@HomyeeKing Thanks, Could you please add a changeset for this PR? Please run |
|
@iosh Done, thanks :) |
the home config was decrepated, so it'd better remove it from here as well.