Improvements to pingerr

[Panchajanya1999]

This pull request introduces significant improvements to both the documentation and the code of pingerr.sh, focusing on usability, accuracy, and maintainability. The highlights are the addition of flexible command-line options, a switch to cache-aware DNS benchmarking using median response times, and a streamlined DNS server list. The README has been updated to reflect these changes, providing clearer instructions and examples.

Usability and CLI improvements:

• Added comprehensive command-line options to pingerr.sh, allowing users to select IPv4/IPv6, set test count, choose test domain, enable quick mode, and control output formatting. The help and version flags are also included. [1] [2]
• The script now validates conflicting options (e.g., prevents simultaneous --ipv4-only and --ipv6-only) and handles IPv6 connectivity checks more robustly. [1] [2]

Benchmarking methodology improvements:

• Changed DNS benchmarking to use a cache-aware approach: a warmup query primes the cache, followed by repeated queries to measure cached response time. The median is used for robust results instead of the average, reducing the impact of outliers. [1] [2] [3]
• Updated output and documentation to consistently report "Median" response time instead of "Average". [1] [2] [3] [4]

DNS server list maintenance:

• Reduced the number of tested DNS servers from 60+ to 50+, removing several outdated or unreliable entries from both IPv4 and IPv6 lists, and updating the README accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Documentation and advanced usage:

• Refactored and expanded the README to provide clear explanations of the benchmarking methodology, command-line options, and advanced usage scenarios, including instructions for customizing the DNS server list and IPv6 testing. [1] [2] [3]

Other improvements:

• Added a version string to the script and implemented a --version flag for easy version tracking. [1] [2]

These changes make pingerr.sh more user-friendly, accurate, and maintainable, and ensure the documentation is up-to-date and helpful for both new and advanced users.

[Copilot]

Pull request overview

This pull request significantly enhances the pingerr DNS benchmarking tool by adding flexible command-line options, improving the benchmarking methodology to use cache-aware testing with median calculations, and streamlining the DNS server list from 60+ to 50+ servers.

Changes:

• Added comprehensive CLI options (-4/-6 for IP version selection, -n for test count, -d for custom domain, -q for quick mode, --no-ping, --no-color, -h, -v)
• Switched from average to median for response time calculations with a warmup query approach that measures cached DNS response times
• Updated DNS server lists by removing outdated servers and consolidating the list to 50+ active servers

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
README.md	Updated documentation to reflect new CLI options, cache-aware testing methodology, command examples, and reduced server count (60+ to 50+)
pingerr.sh	Added CLI argument parsing, median calculation function, warmup query logic, IPv6 option handling, and loop restructuring to fix subshell variable scope issues
pingerr_ash.sh	Implemented same features as pingerr.sh with ash/POSIX-compatible syntax, including printf-based help output and file-based median calculation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The calculate_median function creates temporary files (/tmp/median_$$ and /tmp/median_$$.sorted) that are cleaned up at the end of the function. However, if the function is interrupted before completion (e.g., script killed), these files might not be cleaned up. Consider adding these patterns to the main trap handler or using a more robust cleanup mechanism.

[Copilot]

The calculate_median function uses /tmp/median_$$ for temporary files. Since $$ is the parent shell's PID and this function is called from parallel background jobs (line 550), multiple concurrent calls could create a race condition where jobs overwrite each other's temp files. Consider using $BASHPID or adding a random component to make the temp file names unique per background job, such as /tmp/median_$$_$RANDOM or creating the temp files in the DNS_TEMP_DIR with unique names.

[Copilot]

The validation for the --count argument only checks if the value is numeric but doesn't validate that it's a positive integer. Users could pass zero or negative values like --count 0 or --count -5, which would cause all DNS tests to fail. Consider adding validation to ensure TEST_COUNT is greater than zero.

Suggested change

	if [ -n "$2" ] && [ "$2" -eq "$2" ] 2>/dev/null; then
	TEST_COUNT=$2
	shift 2
	else
	echo "Error: --count requires a numeric argument"
	if [ -n "$2" ] && [ "$2" -eq "$2" ] 2>/dev/null && [ "$2" -gt 0 ] 2>/dev/null; then
	TEST_COUNT=$2
	shift 2
	else
	echo "Error: --count requires a positive numeric argument (greater than 0)"

[Copilot]

The validation for the --count argument only checks if the value is numeric but doesn't validate that it's a positive integer. Users could pass zero or negative values like --count 0 or --count -5, which would cause all DNS tests to fail. Consider adding validation to ensure TEST_COUNT is greater than zero.

Suggested change

	if [ -n "$2" ] && [ "$2" -eq "$2" ] 2>/dev/null; then
	TEST_COUNT=$2
	shift 2
	else
	printf 'Error: --count requires a numeric argument\n'
	if [ -n "$2" ] && [ "$2" -eq "$2" ] 2>/dev/null && [ "$2" -gt 0 ]; then
	TEST_COUNT=$2
	shift 2
	else
	printf 'Error: --count requires a positive integer argument greater than zero\n'