Skip to content

Comments

soyoungjeong.yml#37

Open
soyoungjeong wants to merge 30 commits intoPandelisZ:masterfrom
soyoungjeong:master
Open

soyoungjeong.yml#37
soyoungjeong wants to merge 30 commits intoPandelisZ:masterfrom
soyoungjeong:master

Conversation

@soyoungjeong
Copy link

No description provided.

cdy0510 and others added 30 commits October 11, 2019 13:37
Signing the guestbook! :)
DEVFEST이미지 추가, 문구 수정, 페이스북 링크 추가
안내 문구 한글번역
base repository에 있던 방명록 삭제
새로운 방명록 작성
개인 repo만든 상태에서 upstream(GDG-Seoul)로 이동하여 PR 생성시  PandelisZ/workshop-guestbook 쪽이 base로 PR이 생성됩니다.
환경차이가 있을 수 있겠지만 개인 repo에서 PR 생성시 GDG 쪽으로 PR이 생성되는걸 확인했습니다.
PR에 익숙하지 않은분들을 고려하여 개인 저장소에서 PR을 생성하는쪽이 좋을거같습니다.
@TravisBuddy
Copy link

Travis tests have failed

Hey @soyoungjeong,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.3.1

View build log

yamllint _guestbook/*
_guestbook/dayoung.yaml
  5:81      warning  line too long (93 > 80 characters)  (line-length)

_guestbook/haesunpark.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)
  8:9       error    trailing spaces  (trailing-spaces)

_guestbook/shinye.yaml
  5:81      warning  line too long (134 > 80 characters)  (line-length)

_guestbook/ywkim.yaml
  6:10      error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)
ruby -Itest tests/tests.rb
Loaded suite tests/tests
Started
F
================================================================================
Failure:
  opening --- missing: ./_guestbook/haesunpark.yaml.
  <false> is not true.
test_frontmattervalidation(TestFrontMatterValidation)
tests/tests.rb:13:in `block in test_frontmattervalidation'
     10:             keys = data.keys.map { |k| k.downcase }
     11:             assert(keys.include?("name"), "name missing: #{path}")
     12:             lines = File.readlines(path)
  => 13:             assert("---\n" == lines[0], "opening --- missing: #{path}")
     14:             assert(lines[4..-1].include?("---\n"), "closing --- missing: #{path}")
     15:         end
     16:     end
tests/tests.rb:7:in `each'
tests/tests.rb:7:in `test_frontmattervalidation'
================================================================================


Finished in 0.007084443 seconds.
--------------------------------------------------------------------------------
1 tests, 8 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
--------------------------------------------------------------------------------
141.15 tests/s, 1129.23 assertions/s
TravisBuddy Request Identifier: 8807a3c0-f2e7-11e9-a94e-c51b88d78b8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants