Open
Conversation
Signing the guestbook! :)
Create dayoung.yaml
DEVFEST이미지 추가, 문구 수정, 페이스북 링크 추가
안내 문구 한글번역
base repository에 있던 방명록 삭제
check_in
Create yeonheehan.yaml
Thanks
새로운 방명록 작성
개인 repo만든 상태에서 upstream(GDG-Seoul)로 이동하여 PR 생성시 PandelisZ/workshop-guestbook 쪽이 base로 PR이 생성됩니다. 환경차이가 있을 수 있겠지만 개인 repo에서 PR 생성시 GDG 쪽으로 PR이 생성되는걸 확인했습니다. PR에 익숙하지 않은분들을 고려하여 개인 저장소에서 PR을 생성하는쪽이 좋을거같습니다.
Create Pull request
Update README.md
Create my yaml
포크 버튼 추가 제안
Signing the guestbook
Travis tests have failedHey @jaisuk, Ruby: 2.3.1yamllint _guestbook/*ruby -Itest tests/tests.rbTravisBuddy Request Identifier: a6200990-f2e9-11e9-a94e-c51b88d78b8d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:)