Skip to content

Constant naming #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Constant naming #11

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e473a09
Disable `LexicographicalAnnotationAttributeListing`
Oct 13, 2025
a2d7e52
Disable `LexicographicalAnnotationAttributeListing`
Oct 13, 2025
1063171
Disable `LexicographicalAnnotationAttributeListing`
Oct 13, 2025
ba9ba49
Disable `LexicographicalAnnotationAttributeListing`
Oct 13, 2025
adb136f
Merge branch 'LexicographicalAnnotationListing' into ConstantNaming
Oct 13, 2025
acb1497
Disable `LexicographicalAnnotationAttributeListing`
Oct 13, 2025
0ab08e3
Disable `LexicographicalAnnotationAttributeListing`
Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions gradle/plugins/common/src/main/kotlin/junitbuild.java-nullability-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ tasks.withType<JavaCompile>().configureEach {
"StringSplitter", // We don`t want to use Guava.
"UnnecessaryLambda", // The findings of this check are subjective because a named constant can be more readable in many cases.
// picnic (https://error-prone.picnic.tech)
"ConstantNaming",
"DirectReturn", // https://github.com/junit-team/junit-framework/pull/5006#discussion_r2403984446
// "ConstantNaming",
"DirectReturn", // We don`t want to use this: https://github.com/junit-team/junit-framework/pull/5006#discussion_r2403984446
"FormatStringConcatenation",
"IdentityConversion",
"LexicographicalAnnotationAttributeListing",
"LexicographicalAnnotationListing",
"LexicographicalAnnotationAttributeListing", // We don`t want to use this: https://github.com/junit-team/junit-framework/pull/5043#pullrequestreview-3330615838
"MissingTestCall",
"NestedOptionals",
"NonStaticImport",
Expand All @@ -55,6 +54,13 @@ tasks.withType<JavaCompile>().configureEach {
"PackageLocation",
"RedundantStringConversion",
"RedundantStringEscape",
//"LexicographicalAnnotationListing",
//"ConstantNaming",
)
errorproneArgs.addAll(
"-XepPatchLocation:IN_PLACE",
"-XepPatchChecks:LexicographicalAnnotationListing"
Copy link

@rickie rickie Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this line does work and auto applies changes, but the line below doesn't make any changes? Do you see an error or not?

Do you have twice the -XepPatchChecks when enabling the rule or not?

// "-XepPatchChecks:ConstantNaming" why not working?
)
} else {
disableAllChecks = true
Expand Down