Skip to content

Fix code cleanup #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix code cleanup #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec84770
apply
Jul 12, 2025
f839666
apply
Jul 12, 2025
4bebc4b
apply
Jul 12, 2025
99e7a16
apply
Jul 12, 2025
3e621e3
apply
Jul 12, 2025
9dbd114
apply
Jul 12, 2025
a23f9eb
apply
Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
326 changes: 326 additions & 0 deletions .rewrite/pmd-checkstyle-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,326 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" "https://checkstyle.org/dtds/configuration_1_3.dtd">

<!--
This configuration file was written by the eclipse-cs plugin configuration editor
-->
<!--
Checkstyle-Configuration: pmd-checkstyle-config
Description: none
-->
<module name="Checker">
<property name="severity" value="warning"/>
<module name="TreeWalker">
<module name="AnnotationUseStyle">
<property name="severity" value="error"/>
</module>
<module name="MissingDeprecated">
<property name="severity" value="warning"/>
</module>
<module name="MissingOverride">
<property name="severity" value="warning"/>
</module>
<module name="PackageAnnotation">
<property name="severity" value="error"/>
</module>
<module name="JavadocMethod">
<property name="severity" value="warning"/>
<property name="accessModifiers" value="public,protected"/>
</module>
<module name="JavadocStyle">
<property name="severity" value="warning"/>
<property name="scope" value="protected"/>
<property name="checkEmptyJavadoc" value="true"/>
</module>
<module name="JavadocType">
<property name="severity" value="warning"/>
<property name="scope" value="protected"/>
</module>
<module name="JavadocVariable">
<property name="severity" value="warning"/>
<property name="accessModifiers" value="protected"/>
</module>
<module name="NonEmptyAtclauseDescription">
<property name="severity" value="warning"/>
</module>
<module name="JavadocTagContinuationIndentation">
<property name="severity" value="warning"/>
</module>
<module name="SummaryJavadoc">
<property name="severity" value="warning"/>
</module>
<module name="AtclauseOrder">
<property name="severity" value="warning"/>
</module>
<module name="JavadocParagraph">
<property name="severity" value="warning"/>
</module>
<module name="GenericWhitespace">
<property name="severity" value="error"/>
</module>
<module name="EmptyForInitializerPad">
<property name="severity" value="error"/>
</module>
<module name="EmptyForIteratorPad">
<property name="severity" value="error"/>
</module>
<module name="NoWhitespaceAfter">
<property name="severity" value="error"/>
<property name="tokens" value="BNOT,DEC,DOT,INC,LNOT,UNARY_MINUS,UNARY_PLUS"/>
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="error"/>
</module>
<module name="NoWhitespaceBefore">
<property name="severity" value="error"/>
<property name="allowLineBreaks" value="true"/>
<property name="tokens" value="COMMA,SEMI,DOT,POST_DEC,POST_INC,GENERIC_END"/>
</module>
<module name="OperatorWrap">
<property name="severity" value="error"/>
</module>
<module name="AvoidStarImport">
<property name="severity" value="error"/>
</module>
<module name="IllegalImport">
<property name="severity" value="error"/>
</module>
<module name="ImportOrder">
<property name="severity" value="error"/>
<property name="option" value="top"/>
<property name="groups" value="/^javax?\./,/^org\./,/^net\.sourceforge\.pmd/"/>
<property name="separated" value="true"/>
<property name="sortStaticImportsAlphabetically" value="true"/>
</module>
<module name="RedundantImport">
<property name="severity" value="error"/>
</module>
<module name="UnusedImports">
<property name="severity" value="error"/>
</module>
<module name="MethodParamPad">
<property name="severity" value="error"/>
</module>
<module name="ParenPad">
<property name="severity" value="error"/>
</module>
<module name="TypecastParenPad">
<property name="severity" value="error"/>
</module>
<module name="WhitespaceAfter">
<property name="severity" value="error"/>
</module>
<module name="WhitespaceAround">
<property name="severity" value="error"/>
<property name="tokens" value="ASSIGN,BAND,BAND_ASSIGN,BOR,BOR_ASSIGN,BSR,BSR_ASSIGN,BXOR,BXOR_ASSIGN,COLON,DIV,DIV_ASSIGN,DO_WHILE,EQUAL,GE,GT,LAMBDA,LAND,LCURLY,LE,LITERAL_ASSERT,LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_RETURN,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,LOR,LT,MINUS,MINUS_ASSIGN,MOD,MOD_ASSIGN,NOT_EQUAL,PLUS,PLUS_ASSIGN,QUESTION,RCURLY,SL,SLIST,SL_ASSIGN,SR,SR_ASSIGN,STAR,STAR_ASSIGN,TYPE_EXTENSION_AND"/>
<property name="allowEmptyConstructors" value="true"/>
<property name="allowEmptyMethods" value="true"/>
<property name="allowEmptyLambdas" value="true"/>
</module>
<module name="EmptyLineSeparator">
<property name="severity" value="error"/>
<property name="allowNoEmptyLineBetweenFields" value="true"/>
</module>
<module name="SeparatorWrap">
<property name="severity" value="error"/>
<property name="tokens" value="COMMA,SEMI"/>
</module>
<module name="SingleSpaceSeparator">
<property name="severity" value="error"/>
</module>
<module name="ModifierOrder">
<property name="severity" value="error"/>
</module>
<module name="RedundantModifier">
<property name="severity" value="error"/>
<property name="jdkVersion" value="8"/>
</module>
<module name="EmptyBlock">
<property name="severity" value="warning"/>
</module>
<module name="EmptyCatchBlock">
<property name="severity" value="warning"/>
<property name="exceptionVariableName" value="^ignored$"/>
</module>
<module name="LeftCurly">
<property name="severity" value="error"/>
</module>
<module name="NeedBraces">
<property name="severity" value="error"/>
</module>
<module name="RightCurly">
<property name="severity" value="error"/>
</module>
<module name="DefaultComesLast">
<property name="severity" value="error"/>
</module>
<module name="DeclarationOrder">
<property name="severity" value="warning"/>
</module>
<module name="EqualsHashCode">
<property name="severity" value="error"/>
</module>
<module name="FallThrough">
<property name="severity" value="error"/>
</module>
<module name="HiddenField">
<property name="severity" value="warning"/>
</module>
<module name="IllegalCatch">
<property name="severity" value="warning"/>
</module>
<module name="IllegalThrows">
<property name="severity" value="error"/>
</module>
<module name="InnerAssignment">
<property name="severity" value="error"/>
</module>
<module name="MagicNumber">
<property name="severity" value="warning"/>
<property name="constantWaiverParentToken" value="TYPECAST,METHOD_CALL,EXPR,ARRAY_INIT,UNARY_MINUS,UNARY_PLUS,ELIST,STAR,ASSIGN,PLUS,MINUS,DIV,LITERAL_NEW"/>
</module>
<module name="MissingSwitchDefault">
<property name="severity" value="error"/>
</module>
<module name="ModifiedControlVariable">
<property name="severity" value="error"/>
</module>
<module name="MultipleStringLiterals">
<property name="severity" value="warning"/>
</module>
<module name="MultipleVariableDeclarations">
<property name="severity" value="error"/>
</module>
<module name="PackageDeclaration">
<property name="severity" value="error"/>
</module>
<module name="ParameterAssignment">
<property name="severity" value="warning"/>
</module>
<module name="ReturnCount">
<property name="severity" value="warning"/>
</module>
<module name="SimplifyBooleanExpression">
<property name="severity" value="warning"/>
</module>
<module name="SimplifyBooleanReturn">
<property name="severity" value="warning"/>
</module>
<module name="StringLiteralEquality">
<property name="severity" value="error"/>
</module>
<module name="ArrayTrailingComma">
<property name="severity" value="error"/>
</module>
<module name="UnnecessaryParentheses">
<property name="severity" value="warning"/>
</module>
<module name="OneStatementPerLine">
<property name="severity" value="error"/>
</module>
<module name="InterfaceIsType">
<property name="severity" value="warning"/>
</module>
<module name="OneTopLevelClass">
<property name="severity" value="error"/>
</module>
<module name="BooleanExpressionComplexity">
<property name="severity" value="warning"/>
</module>
<module name="ArrayTypeStyle">
<property name="severity" value="error"/>
</module>
<module name="Indentation">
<property name="severity" value="error"/>
<property name="caseIndent" value="0"/>
</module>
<module name="CommentsIndentation">
<property name="severity" value="error"/>
</module>
<module name="TodoComment">
<property name="severity" value="warning"/>
</module>
<module name="TodoComment">
<property name="severity" value="warning"/>
<property name="format" value="FIXME:"/>
</module>
<module name="UpperEll">
<property name="severity" value="error"/>
</module>
<module name="OuterTypeFilename">
<property name="severity" value="error"/>
</module>
<module name="HideUtilityClassConstructor">
<property name="severity" value="error"/>
</module>
<module name="EmptyStatement">
<property name="severity" value="error"/>
</module>
<module name="EqualsAvoidNull">
<property name="severity" value="error"/>
</module>
<module name="AnnotationLocation">
<property name="severity" value="error"/>
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="error"/>
</module>
<module name="ConstantName">
<property name="severity" value="error"/>
</module>
<module name="LocalVariableName">
<property name="severity" value="error"/>
<property name="allowOneCharVarInForLoop" value="true"/>
</module>
<module name="MemberName">
<property name="severity" value="error"/>
</module>
<module name="MethodName">
<property name="severity" value="error"/>
</module>
<module name="PackageName">
<property name="severity" value="error"/>
</module>
<module name="ParameterName">
<property name="severity" value="error"/>
</module>
<module name="StaticVariableName">
<property name="severity" value="error"/>
</module>
<module name="TypeName">
<property name="severity" value="error"/>
</module>
<module name="ClassTypeParameterName">
<property name="severity" value="error"/>
</module>
<module name="MethodTypeParameterName">
<property name="severity" value="error"/>
</module>
<module name="InterfaceTypeParameterName">
<property name="severity" value="error"/>
</module>
<module name="AbbreviationAsWordInName">
<property name="severity" value="warning"/>
<property name="allowedAbbreviationLength" value="1"/>
<property name="allowedAbbreviations" value="PMD,EOF,AST"/>
</module>
<module name="SuppressWithNearbyCommentFilter"/>
</module>
<module name="JavadocPackage">
<property name="severity" value="warning"/>
</module>
<module name="RegexpHeader">
<property name="severity" value="error"/>
<property name="header" value="^\/\*\*?[ ]*$\n^[ ]+\*[ ]+BSD-style license; for more info see http:\/\/pmd.sourceforge.net/license.html[ ]*\n[ ]+\*\/[ ]*$"/>
<property name="fileExtensions" value="java,less,kt"/>
</module>
<module name="RegexpHeader">
<property name="severity" value="error"/>
<property name="header" value="^#$\n^# BSD-style license; for more info see http:\/\/pmd.sourceforge.net/license.html$\n^#$"/>
<property name="fileExtensions" value="properties"/>
</module>
<module name="FileTabCharacter">
<property name="severity" value="error"/>
</module>
<module name="NewlineAtEndOfFile">
<property name="severity" value="error"/>
<property name="lineSeparator" value="system"/>
</module>
<module name="SuppressWithPlainTextCommentFilter"/>
</module>
24 changes: 13 additions & 11 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,41 +482,43 @@
<version>6.12.1</version>
<configuration>
<exclusions>
<exclusion>**AbstractJavaRule.java</exclusion>
<exclusion>**AbstractPLSQLRule.java</exclusion>
<exclusion>**Chars.java</exclusion> <!-- // @SuppressWarnings("PMD.MissingOverride") -->
<exclusion>**DesignerCommand.java</exclusion>
<exclusion>**Jep441_PatternMatchingForSwitch.java</exclusion>
<exclusion>**MatchAlgorithm.java</exclusion>
<exclusion>**PmdRootCommand.java</exclusion>
<exclusion>**TypeScriptLexerBase.java</exclusion>
<exclusion>**TypeSystem.java</exclusion>
<exclusion>**generated-sources**</exclusion>
<exclusion>**testdata**</exclusion>
</exclusions>
<activeRecipes>
<recipe>org.openrewrite.staticanalysis.CodeCleanup</recipe>
<recipe>org.openrewrite.staticanalysis.ModifierOrder</recipe>
<recipe>org.openrewrite.text.EndOfLineAtEndOfFile</recipe>
<!-- <recipe>org.openrewrite.java.RemoveUnusedImports</recipe>-->
<!-- <recipe>org.openrewrite.java.format.AutoFormat</recipe>-->
<!-- <recipe>org.openrewrite.java.format.BlankLines</recipe>-->
<!-- <recipe>org.openrewrite.java.format.NormalizeFormat</recipe>-->
<!-- <recipe>org.openrewrite.java.format.NormalizeLineBreaks</recipe>-->
<!-- <recipe>org.openrewrite.java.format.RemoveTrailingWhitespace</recipe>-->
<!-- <recipe>org.openrewrite.java.format.Spaces</recipe>-->
<!-- <recipe>org.openrewrite.java.format.TabsAndIndents</recipe>-->
<!-- <recipe>org.openrewrite.java.format.WrappingAndBraces</recipe>-->
<!-- <recipe>org.openrewrite.java.migrate.UpgradeToJava17</recipe>-->
<!-- <recipe>org.openrewrite.java.migrate.UpgradeToJava21</recipe>-->
<!-- <recipe>org.openrewrite.java.testing.assertj.Assertj</recipe>-->
<!-- <recipe>org.openrewrite.java.testing.cleanup.AssertTrueNullToAssertNull</recipe>-->
<!-- <recipe>org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic</recipe>-->
<!-- <recipe>org.openrewrite.java.testing.junit5.JUnit5BestPractices</recipe>-->
<!-- <recipe>org.openrewrite.maven.OrderPomElements</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.CodeCleanup</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.CommonStaticAnalysis</recipe>-->
<recipe>org.openrewrite.staticanalysis.EqualsAvoidsNull</recipe>
<!-- <recipe>org.openrewrite.staticanalysis.EqualsAvoidsNull</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.FinalizeLocalVariables</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.MissingOverrideAnnotation</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.ModifierOrder</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.RedundantFileCreation</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.RemoveUnusedLocalVariables</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateFields</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods</recipe>-->
<!-- <recipe>org.openrewrite.staticanalysis.StringLiteralEquality</recipe>-->
<!-- <recipe>org.openrewrite.text.EndOfLineAtEndOfFile</recipe>-->
</activeRecipes>
<failOnDryRunResults>true</failOnDryRunResults>
<checkstyleConfigFile>.rewrite/pmd-checkstyle-config.xml</checkstyleConfigFile>
<rewriteSkip>${rewrite.skip}</rewriteSkip>
</configuration>
<executions>
Expand Down
Loading