Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take an example from the data component api:
For the equipment sound and similar methods taking some kind of key, we have wonderful Key classes that unfortunately aren't actually keys. So
Sound.TYPE.key()ends up being less annoying to use thanSoundEventKeys.TYPE.key()(though still annoying). Being able to actually useSoundEventKeys.TYPEas an argument makes it more likely for people to prefer it over the enums/enum-like registry valuesKey extends Keyed, so this won't break existing plugins