Skip to content

Conversation

@kokiriglade
Copy link
Contributor

No description provided.

@kokiriglade kokiriglade requested a review from a team as a code owner November 23, 2024 14:35
@lynxplay
Copy link
Contributor

Your tests are failing.
Also this diff should be merged into the existing patch for registry entries and builders.
Add yourself as a co-author obviously, but no point in a new patch.

Shared diff, like the one in Conversions, should go into the appropriate Registry Modification patch too.

@kokiriglade
Copy link
Contributor Author

should be fixed now, sorry about that. I had some trouble moving the patch around, but I think it's OK

@lynxplay lynxplay merged commit 6051dac into PaperMC:master Nov 23, 2024
3 checks passed
@kokiriglade kokiriglade deleted the painting-variant-modification branch November 23, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants