Brigadier: fix simpleUnwrap not keeping redirect modifier and forks properties from original node #11654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owen1212055
approved these changes
Dec 8, 2024
lynxplay
approved these changes
Dec 8, 2024
…roperties from original node
Owen1212055
force-pushed
the
fix-brigadier-redirect
branch
from
a4a4d7d to
9deb599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ArgumentBuilder, the
redirectmethod resets the values of the propertiesmodifierandforksto null and false respectively.This prevented the Brigadier commands registered during the Lifecycle event to use any redirect using the fork method.
This PR changes the use of the
redirectmethod by theforwardmethod to directly set the 3 forwarding related properties.