Skip to content

Conversation

@Leguan16
Copy link
Contributor

Removes the unused config option that enabled string duping.

@Leguan16 Leguan16 requested a review from a team as a code owner November 26, 2024 18:50
@Leguan16 Leguan16 force-pushed the remove-string-dupe-exploit-setting branch from c27e1a9 to f992cbf Compare November 26, 2024 19:03
@electronicboy
Copy link
Member

This also needs to be added into the thing to remove old keys, I think?

@lynxplay
Copy link
Contributor

And a follow up docs PR 👍

@Leguan16
Copy link
Contributor Author

And a follow up docs PR 👍

I know I just wanted to wait until I have confirmation that it's actually obsolete. I will open the PR shortly.

@Leguan16 Leguan16 force-pushed the remove-string-dupe-exploit-setting branch from f992cbf to d26a387 Compare November 26, 2024 19:19
@electronicboy
Copy link
Member

Yes, it's obsolete as mojang fixed this themselves

@Leguan16
Copy link
Contributor Author

I think everything should be good to go now.

@lynxplay lynxplay force-pushed the remove-string-dupe-exploit-setting branch from d26a387 to 9df0e87 Compare November 27, 2024 21:23
@lynxplay lynxplay merged commit cb2ab7d into PaperMC:master Nov 28, 2024
3 checks passed
@Leguan16 Leguan16 deleted the remove-string-dupe-exploit-setting branch December 8, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants