Re-add shear methods from bukkit Shearable#11714
Closed
HaHaWTH wants to merge 1 commit intoPaperMC:masterfrom
Closed
Re-add shear methods from bukkit Shearable#11714HaHaWTH wants to merge 1 commit intoPaperMC:masterfrom
HaHaWTH wants to merge 1 commit intoPaperMC:masterfrom
Conversation
|
Please do not open pull requests from the |
Member
|
We should expose what "sheared" represents, rather then just expanding the usage of flawed API; (and that should be added to the existing entity API patch) |
Contributor
Author
Thanks for explanation! Should I add this to Missing Entity API patch? |
Member
|
Yes |
Member
|
Oh, actually, both of them called the internal data shreared, so, this is fine; Snowmen already have their "derp"'d methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request closes #11638.
Changes made
Readd shear related methods to Sheep and Bogged from bukkit Shearable.
This is my first PR to Paper, sorry if i did something wrong.