Skip to content

Fix Player.setPlayerListOrder to send update to clients #11729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 5 commits into from
Dec 11, 2024
Merged

Fix Player.setPlayerListOrder to send update to clients #11729

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4128c69
Fix Player.setPlayerListOrder to send update to clients
96DarkCode96 Dec 10, 2024
9c855b2
Fix Player.setPlayerListOrder to send update to clients
96DarkCode96 Dec 10, 2024
89e3406
Merge branch 'PaperMC:master' into fix/playerListOrder
96DarkCode96 Dec 11, 2024
f21ff43
Reverting incorrect changes (isListed API)
96DarkCode96 Dec 11, 2024
47a4a25
Move back
kennytv Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions patches/server/1076-Fix-Player.setPlayerListOrder-to-send-update-to-clie.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: 96DarkCode96 <96darkcode96@gmail.com>
Date: Tue, 10 Dec 2024 15:45:47 +0100
Subject: [PATCH] Fix Player.setPlayerListOrder to send update to clients


diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
index 20f64850cb42d986358f01ffcdb42187e1684bca..b60f547c8616e9d4a858e79d036712f311152aea 100644
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
@@ -606,6 +606,14 @@ public class CraftPlayer extends CraftHumanEntity implements Player {
Preconditions.checkArgument(order >= 0, "order cannot be negative");

this.getHandle().listOrder = order;
+ // Paper start - Send update packet
+ if (getHandle().connection == null) return; // Updates are possible before the player has fully joined
+ for (ServerPlayer player : server.getHandle().players) {
+ if (player.getBukkitEntity().canSee(this)) {
+ player.connection.send(new ClientboundPlayerInfoUpdatePacket(ClientboundPlayerInfoUpdatePacket.Action.UPDATE_LIST_ORDER, getHandle()));
+ }
+ }
+ // Paper end - Send update packet
}

private net.kyori.adventure.text.Component playerListHeader; // Paper - Adventure
Loading