Call PlayerItemDamageEvent for tridents#11899
Conversation
|
I am unsure if breaking actually works here given that LivingEntity#onEquippedItemBroken isn't called if the item breaks. |
|
so all it seems to do is send the breaking packet to the client and removing modifiers from the itemstack (which i am not sure is necessary? considering its breaking anyways). using setDamage(reallyhighnumber) when throwing the trident without riptide it just gets stuck in the ground and can't be picked up anymore which i guess is to be expected, when using with riptide it just breaks but still gives you the boost. not sure whether disallowing breaking the trident, changing the onBreak Consumer or just leaving it as is is the best option |
f18ab9b to
954f66a
Compare
|
For now, the event won't allow for breaking the itemstack, mostly because doing so is down the line upkeep to ensure no caller expects the item to remain. If people end up requesting this specific feature, we can revisit this and potentially enable this, but util we have requests it isn't worth the upkeep. |
fixes #11655
pre hardfork #11716