Add EntityEquipmentChangedEvent #12011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorrrr
reviewed
Feb 10, 2025
Member
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
The naming and approach of this PR seems good to me
paper-api/src/main/java/io/papermc/paper/event/entity/EntityEquipmentChangedEvent.java
Show resolved
Hide resolved
TonytheMacaroni
force-pushed
the
equip-event
branch
from
7552122 to
9e163a4
Compare
Warriorrrr
approved these changes
Feb 10, 2025
lynxplay
requested changes
Feb 12, 2025
paper-api/src/main/java/io/papermc/paper/event/entity/EntityEquipmentChangedEvent.java
Outdated
Show resolved
Hide resolved
paper-api/src/main/java/io/papermc/paper/event/entity/EntityEquipmentChangedEvent.java
Outdated
Show resolved
Hide resolved
lynxplay
approved these changes
Feb 16, 2025
Y2Kwastaken
pushed a commit
to Y2Kwastaken/Paper
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #11667.
Opted to implement the alternative mentioned in the previous PR, which instead exposes of changed slots -> equipment changes. Feedback on naming and the approach would be appreciated.